Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint related packages #48513

Merged
merged 25 commits into from
Oct 21, 2019
Merged

Update eslint related packages #48513

merged 25 commits into from
Oct 21, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 17, 2019

This PR contains the following updates:

Package Type Update Change
@types/eslint devDependencies major ^4.16.8 -> ^6.1.2
eslint (source) peerDependencies major 5.16.0 -> 6.5.1
eslint (source) devDependencies major 5.16.0 -> 6.5.1
eslint-config-prettier devDependencies minor 6.3.0 -> 6.4.0
eslint-plugin-cypress devDependencies minor ^2.6.1 -> ^2.7.0
eslint-plugin-node devDependencies major 9.2.0 -> 10.0.0

Release Notes

eslint/eslint

v6.5.1

Compare Source

  • 0d3d7d9 Docs: fix typo in no-magic-numbers (#​12345) (Josiah Rooney)
  • 447ac87 Fix: no-useless-rename handles ExperimentalRestProperty (fixes #​12335) (#​12339) (Kai Cataldo)
  • b6ff73c Sponsors: Sync README with website (ESLint Jenkins)

v6.5.0

Compare Source

  • 73596cb Update: Add enforceForSwitchCase option to use-isnan (#​12106) (Milos Djermanovic)
  • d592a24 Fix: exclude \u000d so new line won't convert to text (fixes #​12027) (#​12031) (zamboney)
  • e85d27a Fix: no-regex-spaces false positives and invalid autofix (fixes #​12226) (#​12231) (Milos Djermanovic)
  • b349bf7 Fix: prefer-named-capture-group incorrect locations (fixes #​12233) (#​12247) (Milos Djermanovic)
  • 7dc1ea9 Fix: no-useless-return autofix removes comments (#​12292) (Milos Djermanovic)
  • 0e68677 Fix: no-extra-bind autofix removes comments (#​12293) (Milos Djermanovic)
  • 6ad7e86 Fix: no-extra-label autofix removes comments (#​12298) (Milos Djermanovic)
  • acec201 Fix: no-undef-init autofix removes comments (#​12299) (Milos Djermanovic)
  • d89390b Fix: use async reading of stdin in bin/eslint.js (fixes #​12212) (#​12230) (Barrie Treloar)
  • 334ca7c Update: no-useless-rename also reports default values (fixes #​12301) (#​12322) (Kai Cataldo)
  • 41bfe91 Update: Fix handling of chained new expressions in new-parens (#​12303) (Milos Djermanovic)
  • 160b7c4 Chore: add autofix npm script (#​12330) (Kai Cataldo)
  • 04b6adb Chore: enable eslint-plugin-jsdoc (refs #​11146) (#​12332) (Kai Cataldo)
  • 9b86167 Docs: Add new ES environments to Configuring ESLint (#​12289) (Milos Djermanovic)
  • c9aeab2 Docs: Add supported ECMAScript version to README (#​12290) (Milos Djermanovic)
  • 8316e7b Fix: no-useless-rename autofix removes comments (#​12300) (Milos Djermanovic)
  • 29c12f1 Chore: cache results in runtime-info (#​12320) (Kai Cataldo)
  • f5537b2 Fix: prefer-numeric-literals autofix removes comments (#​12313) (Milos Djermanovic)
  • 11ae6fc Update: Fix call, new and member expressions in no-extra-parens (#​12302) (Milos Djermanovic)
  • a7894eb New: add --env-info flag to CLI (#​12270) (Kai Cataldo)
  • 61392ff Sponsors: Sync README with website (ESLint Jenkins)
  • 2c6bf8e Docs: English fix (#​12306) (Daniel Nixon)
  • 6f11877 Sponsors: Sync README with website (ESLint Jenkins)
  • 2e202ca Docs: fix links in array-callback-return (#​12288) (Milos Djermanovic)
  • e39c631 Docs: add example for CLIEngine#executeOnText 3rd arg (#​12286) (Kai Cataldo)
  • d4f9a16 Update: add support for JSXFragments in indent rule (fixes #​12208) (#​12210) (Kai Cataldo)
  • c6af95f Sponsors: Sync README with website (ESLint Jenkins)
  • 8cadd52 Sponsors: Sync README with website (ESLint Jenkins)
  • f9fc695 Chore: enable default-param-last (#​12244) (薛定谔的猫)
  • 9984c3e Docs: Update README team and sponsors (ESLint Jenkins)

v6.4.0

Compare Source

  • e915fff Docs: Improve examples and clarify default option (#​12067) (Yuping Zuo)
  • 540296f Update: enforceForClassMembers option to accessor-pairs (fixes #​12063) (#​12192) (Milos Djermanovic)
  • d3c2334 Update: flag nested block with declaration as error (#​12193) (David Waller)
  • b2498d2 Update: Fix handling of property names in no-self-assign (#​12105) (Milos Djermanovic)
  • 1ee61b0 Update: enforceForClassMembers computed-property-spacing (fixes #​12049) (#​12214) (Milos Djermanovic)
  • 520c922 Docs: Added naming convention details to plugin usage (#​12202) (Henrique Barcelos)
  • f826eab Fix: Allow line comment exception in object-curly-spacing (fixes #​11902) (#​12216) (Milos Djermanovic)
  • db2a29b Update: indentation of comment followed by semicolon (fixes #​12232) (#​12243) (Kai Cataldo)
  • ae17d1c Fix: no-sequences is reporting incorrect locations (#​12241) (Milos Djermanovic)
  • 365331a Fix: object-shorthand providing invalid fixes for typescript (#​12260) (Brad Zacher)
  • 1c921c6 New: add no-import-assign (fixes #​12237) (#​12252) (Toru Nagashima)
  • 3be04fd New: Add prefer-regex-literals rule (fixes #​12238) (#​12254) (Milos Djermanovic)
  • 37c0fde Update: Report global Atomics calls in no-obj-calls (fixes #​12234) (#​12258) (Milos Djermanovic)
  • 985c9e5 Fix: space-before-function-paren autofix removes comments (fixes #​12259) (#​12264) (Milos Djermanovic)
  • 01da7d0 Fix: eqeqeq rule reports incorrect locations (#​12265) (Milos Djermanovic)
  • 319e4d8 Docs: adding finally example (#​12256) (Jens Melgaard)
  • d52328f Docs: fix no-sequences with examples (#​12239) (Milos Djermanovic)
  • a41fdc0 Fix: Remove autofixer for no-unsafe-negation (#​12157) (Milos Djermanovic)
  • e38f5fd Update: fix no-octal-escape false negatives after \0 (#​12079) (Milos Djermanovic)
  • 9418fbe Sponsors: Sync README with website (ESLint Jenkins)
  • acc5ec5 Sponsors: Sync README with website (ESLint Jenkins)
  • 460c5ad Sponsors: Sync README with website (ESLint Jenkins)
  • 0313441 New: add rule default-param-last (fixes #​11361) (#​12188) (Chiawen Chen)
  • 7621f5d Update: add more specific linting messages to space-in-parens (#​11121) (Che Fisher)
  • 21eb904 Fix: basePath of OverrideTester (fixes #​12032) (#​12205) (Toru Nagashima)
  • 86e5e65 Sponsors: Sync README with website (ESLint Jenkins)
  • 2b1a13f Fix: no-extra-boolean-cast reports wrong negation node (fixes #​11324) (#​12197) (Milos Djermanovic)
  • ba8c2aa Sponsors: Sync README with website (ESLint Jenkins)
  • a0a9746 Docs: Fix link in no-irregular-whitespace.md (#​12196) (Timo Tijhof)
  • e10eeba Fix: quotes autofix produces syntax error with octal escape sequences (#​12118) (Milos Djermanovic)

v6.3.0

Compare Source

v6.2.2

Compare Source

  • 0e0b784 Upgrade: espree@^6.1.1 (#​12158) (Kevin Partington)
  • 04e859f Sponsors: Sync README with website (ESLint Jenkins)
  • 34783d1 Sponsors: Sync README with website (ESLint Jenkins)
  • b809e72 Docs: Update README team and sponsors (ESLint Jenkins)

v6.2.1

Compare Source

  • 8c021b5 Upgrade: eslint-utils 1.4.2 (#​12131) (Toru Nagashima)
  • e82388b Sponsors: Sync README with website (ESLint Jenkins)
  • 4aeeeed Docs: update docs for ecmaVersion 2020 (#​12120) (silverwind)
  • 6886148 Docs: Add duplicate keys limitation to accessor-pairs (#​12124) (Milos Djermanovic)

v6.2.0

Compare Source

  • fee6acb Update: support bigint and dynamic import (refs #​11803) (#​11983) (Toru Nagashima)
  • afd8012 New: noInlineConfig setting (refs eslint/rfcs#​22) (#​12091) (Toru Nagashima)
  • 3d12378 Update: Fix accessor-pairs to enforce pairs per property in literals (#​12062) (Milos Djermanovic)
  • 8cd00b3 New: function-call-argument-newline (#​12024) (finico)
  • 30ebf92 Fix: prefer-template autofix produces syntax error with octal escapes (#​12085) (Milos Djermanovic)
  • 13c3988 Fix: Check literal type explicitly in dot-notation (#​12095) (Milos Djermanovic)
  • 3e5ceca Fix: Handle empty string property names in getFunctionNameWithKind (#​12104) (Milos Djermanovic)
  • 9a043ff Fix: no-duplicate-case false positives on Object.prototype keys (#​12107) (Milos Djermanovic)
  • fe631af Chore: minor typo fix (#​12112) (James George)
  • 4cb7877 Fix: fix no-extra-parens ignores some nodes (#​11909) (Pig Fang)
  • 2dc23b8 Update: fix no-dupe-keys false negatives on empty string names (#​12069) (Milos Djermanovic)
  • 19ab666 Fix: yoda exceptRange false positives on empty string property names (#​12071) (Milos Djermanovic)
  • d642150 Update: Check empty string property names in sort-keys (#​12073) (Milos Djermanovic)
  • acce6de Fix: class-methods-use-this reports 'undefined' names (#​12103) (Milos Djermanovic)
  • 92ec2cb Fix: Allow bind call with a single spread element in no-extra-bind (#​12088) (Milos Djermanovic)
  • bfdb0c9 Fix: no-extra-boolean-cast invalid autofix for Boolean() without args (#​12076) (Milos Djermanovic)
  • 34ccc0c Chore: Remove TDZ scope type condition from no-unused-vars (#​12055) (Milos Djermanovic)
  • 01d38ce Docs: Remove TDZ scope from the scope manager interface documentation (#​12054) (Milos Djermanovic)
  • 1aff8fc Update: warn about mixing ternary and logical operators (fixes #​11704) (#​12001) (Karthik Priyadarshan)
  • 11be2f8 Docs: do not recommend global-installed usage (#​12016) (薛定谔的猫)
  • cf31dab Fix: no-restricted-syntax - correct the schema (#​12051) (Brad Zacher)
  • fbec99e Update: fix class-methods-use-this false negatives with exceptMethods (#​12077) (Milos Djermanovic)
  • fb08b7c Docs: Remove readonly/writable global logic from no-undef (fixes #​11963) (#​12053) (Milos Djermanovic)
  • 5b5934b Sponsors: Sync README with website (ESLint Jenkins)
  • 9156760 Sponsors: Sync README with website (ESLint Jenkins)
  • f5e0cc4 Update: Check computed method keys in no-extra-parens (#​11973) (Milos Djermanovic)
  • d961438 Docs: Fix Incorrect Documentation (#​12045) (Michael Miceli)
  • 887d08c Sponsors: Sync README with website (ESLint Jenkins)
  • d90183f Docs: add a case to func-names (#​12038) (Chiawen Chen)
  • 8a5b62d Docs: no use eslint.linter in code example (#​12037) (薛定谔的猫)
  • 5831767 Update: report location of func-names (fixes #​12022) (#​12028) (Pig Fang)

v6.1.0

Compare Source

v6.0.1

Compare Source

v6.0.0

Compare Source

prettier/eslint-config-prettier

v6.4.0

Compare Source

  • Added: [unicorn/no-nested-ternary]. Thanks to Yang Mingshan
    (@​yangmingshan)!
cypress-io/eslint-plugin-cypress

v2.7.0

Compare Source

Features
mysticatea/eslint-plugin-node

v10.0.0

Compare Source

This release supports BigInt and Dynamic Imports if you are using ESLint 6.2.0 or later.

💥 Breaking Changes

  • 9ea67c9 updated node/no-unsupported-features/es-syntax rule to recognize BigInt literals and import().
  • b91b48d updated node/no-unsupported-features/es-builtins rule to recognize BigInt, BigInt64Array, BigUint64Array, and Promise.allSettled.
  • b57a4f9 updated node/file-extension-in-import, node/no-extraneous-import, node/no-missing-import, and node/no-unpublished-import rules to recognize import().
  • 4b9c4d7 updated node/no-deprecated-api rule to recognize module.createRequireFromPath.
  • 9c574ba updated plugin:node/recommended and the other configs.
    • It added node/no-exports-assign rule.
    • It changed exports global variable writable.
    • It enabled node/*-import rules in CommonJS mode as well.

✨ New rules

  • a0f0ee1 added node/no-exports-assign rule that disallows exports = {}.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates renovate:major Renovate dependency update with major version updates v7.5.0 v8.0.0 labels Oct 17, 2019
@timroes timroes mentioned this pull request Oct 17, 2019
15 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@renovate
Copy link
Contributor Author

renovate bot commented Oct 18, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@renovate renovate bot requested a review from a team as a code owner October 21, 2019 19:02
@renovate renovate bot requested a review from a team October 21, 2019 19:02
@renovate renovate bot requested review from a team as code owners October 21, 2019 19:02
@renovate renovate bot requested a review from a team October 21, 2019 19:02
@renovate renovate bot requested a review from a team as a code owner October 21, 2019 19:02
@spalger spalger added v7.6.0 and removed v7.5.0 labels Oct 21, 2019
@@ -622,7 +641,6 @@ module.exports = {
// will introduced after the other warns are fixed
// 'react/sort-comp': 'error',
'react/void-dom-elements-no-children': 'error',
'react/jsx-boolean-value': ['error', 'warn'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration is invalid, which caused this to be a noop, so I removed it.

@@ -40,6 +40,7 @@ bower_components
/x-pack/legacy/plugins/infra/public/graphql/types.ts
/x-pack/legacy/plugins/infra/server/graphql/types.ts
/x-pack/legacy/plugins/apm/cypress/**/snapshots.js
/src/legacy/plugin_discovery/plugin_pack/__tests__/fixtures/plugins/broken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The globbing has been improved a little so the code in this directory was being tested now.

@@ -18,4 +18,4 @@
*/

// eslint-disable-next-line import/no-default-export
export default function(selector: string): string;
export default function kbnTestSubjSelector(selector: string): string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -71,7 +71,7 @@ export class PluginWrapper<
private instance?: Plugin<TSetup, TStart, TPluginsSetup, TPluginsStart>;

constructor(
readonly discoveredPlugin: DiscoveredPlugin,
public readonly discoveredPlugin: DiscoveredPlugin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and other instances of adding public modifiers are necessary because of typescript-eslint/typescript-eslint#857, which prevented property parameters created using the readonly keyword from being validated like normal.

Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM-related stuff looks good! 👍

@@ -20,16 +20,16 @@
const os = require('os');
const path = require('path');

function useBat(bin) {
function maybeUseBat(bin) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This triggers React hooks checks

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes lgtm
EDIT: nvm @smith already approved :)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@renovate renovate bot requested a review from a team as a code owner October 21, 2019 21:13
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform changes LGTM

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana App changes look good to me. Skimmed over the rest, that also looks good so far.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor

spalger commented Oct 21, 2019

I don't think the changes justify waiting for more LGTMs, and this is at pretty high risk of reaching conflict hell. @elastic/kibana-canvas @elastic/kibana-stack-services @elastic/logs-metrics-ui @elastic/kibana-operations I'm going to merge this in an hour or so, if you want to take a look first please do.

@spalger spalger merged commit feceb0f into master Oct 21, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Oct 21, 2019
* Update eslint related packages

* add errorMessage to no-restricted-paths validation

* add license to eslintrc file

* ignore broken plugin fixture

* upgrade tangled peer deps

* give name to unnamed func to avoid typescript-eslint/typescript-eslint#1078

* migrate away from removed prefer-interface

* migrate away from removed no-angle-bracket-type-assertions rule

* migrate away from removed no-triple-slash-reference rule

* old config was invalid and made this rule a noop

* fix array-type rule config

* fix readonly paramProperties that weren't being checked

* fix propType ordering

* remove references to non-existent rules

* remove unnecessary disable that is improperly formatted

* fix comment-related spacing

* fix typo/invalid namespace overrides

* rename fn to avoid hook-alike behavior

* remove reference to old removed rule

* use caret version for prettier

* reference babel-eslint with absolute path
@renovate renovate bot deleted the renovate/eslint branch October 21, 2019 23:40
spalger pushed a commit that referenced this pull request Oct 22, 2019
* Update eslint related packages

* add errorMessage to no-restricted-paths validation

* add license to eslintrc file

* ignore broken plugin fixture

* upgrade tangled peer deps

* give name to unnamed func to avoid typescript-eslint/typescript-eslint#1078

* migrate away from removed prefer-interface

* migrate away from removed no-angle-bracket-type-assertions rule

* migrate away from removed no-triple-slash-reference rule

* old config was invalid and made this rule a noop

* fix array-type rule config

* fix readonly paramProperties that weren't being checked

* fix propType ordering

* remove references to non-existent rules

* remove unnecessary disable that is improperly formatted

* fix comment-related spacing

* fix typo/invalid namespace overrides

* rename fn to avoid hook-alike behavior

* remove reference to old removed rule

* use caret version for prettier

* reference babel-eslint with absolute path
@spalger
Copy link
Contributor

spalger commented Oct 22, 2019

7.x/7.6: 0bed689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes renovate:major Renovate dependency update with major version updates renovate Renovate dependency update with major version updates v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants