[Monitoring] Ensure cloud cannot see setup mode #49223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
changed the title
chrisronline
added
Feature:Stack Monitoring
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@igoristic Would love any feedback on how to make 72b8a67 better :( |
cachedout
approved these changes
Oct 24, 2019
💔 Build Failed |
@chrisronline function setModules(isOnCloud = false) {
jest.clearAllMocks().resetModules();
injectorModulesMock.globalState.inSetupMode = false;
jest.doMock('ui/chrome', () => ({
getInjected: (key) => {
if (key === 'isOnCloud') {
return isOnCloud;
}
}
}));
const setupMode = require('./setup_mode');
toggleSetupMode = setupMode.toggleSetupMode;
initSetupModeState = setupMode.initSetupModeState;
getSetupModeState = setupMode.getSetupModeState;
updateSetupModeData = setupMode.updateSetupModeData;
setSetupModeMenuItem = setupMode.setSetupModeMenuItem;
}So, now instead of this: https://github.com/elastic/kibana/pull/49223/files#diff-16124668cbf2ae94c6eafa83ae18894fL112-R133 I would just call |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
This was referenced Nov 4, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Nov 4, 2019
* Ensure cloud cannot see setup mode * Remove cloud check from collection status, as it's an injected var now * Man these tests suck
chrisronline
added a commit
that referenced
this pull request
Nov 5, 2019
chrisronline
added a commit
that referenced
this pull request
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49225
To test, pull down this PR and manually ensure
isOnCloudistruehere