Correctly process paths in mapOf and recordOf. Do not swallow and use indent for nested oneOf error messages.
#49457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
bug
|
Pinging @elastic/kibana-platform (Team:Platform) |
azasypkin
added
the
release_note:skip
…nd use indent for nested `one_of` error messages.
azasypkin
force-pushed
the
issue-xxx-kbn-config-schema
branch
from
0b9f235
to
97a55c9
Compare
💚 Build Succeeded |
mshustov
approved these changes
Oct 28, 2019
|
7.x/7.6.0: 9664c0a |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #46145 noticed a few deficiencies in
kbn/config-schema:oneOfare swallowed and not properly indentedmapOfandrecordOfuse incorrect "path" while constructing error messages and hence lose full path that make it super hard to debug schema violations