Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Remove inferred edges leftover code #50006

Merged
merged 4 commits into from
Nov 11, 2019

Conversation

flash1293
Copy link
Contributor

Graph used to contain a feature called "inferred edges". This feature is disabled and inaccessible. This PR removes all code dedicated to inferred edges from the code base to make refactoring and migrating easier. If we decide to put inferred edges back into the product, we can do so later.

@flash1293 flash1293 added Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 labels Nov 3, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@flash1293 flash1293 marked this pull request as ready for review November 3, 2019 16:55
@flash1293 flash1293 requested a review from a team November 3, 2019 16:55
@flash1293 flash1293 requested a review from a team as a code owner November 3, 2019 16:55
@flash1293 flash1293 mentioned this pull request Nov 4, 2019
31 tasks
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally in Chrome

@kertal
Copy link
Member

kertal commented Nov 11, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@flash1293
Copy link
Contributor Author

Jenkins, test this. Unrelated error in ML

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants