Improve "Browser client is out of date" error message #50296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yep! |
💔 Build Failed |
|
retest |
💔 Build Failed |
joshdover
approved these changes
Nov 12, 2019
Co-Authored-By: Josh Dover <me@joshdover.com>
💔 Build Failed |
|
@elasticmachine merge upstream |
💔 Build Failed |
dgieselaar
approved these changes
Nov 15, 2019
💔 Build Failed |
💚 Build Succeeded |
sorenlouv
deleted the
improve-error-message-for-kbn-version-mistmatch
branch
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Nov 16, 2019
* improve "Browser client is out of date" error message * Improve wording of error message Co-Authored-By: Josh Dover <me@joshdover.com> * Fox formatting * Fix format
sorenlouv
added a commit
that referenced
this pull request
Nov 17, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...
|
Removing the test plan label as this is a Kibana change, not an APM specific change and it's just a text update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6021
This doesn't make the message context dependent but provides some useful debugging information for the API usecase. It might not be super relevant for the browser usecase but I think the added value adds up for the slightly more verbose message.
@jalvz would this change make the error message clearer in your case?