Revert chromedriver update #50324
Merged
Revert chromedriver update #50324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4a696b9.
|
cc @dmlemeshko FYI. Thanks @flash1293 |
|
Ping @dmlemeshko - I checked the commit history and this one is close to the point in time things started to go south. Not sure whether that's just bad luck though. Did you run the new version somewhere else a few times? Also I'm not sure whether this is a 7.x or a master thing - most failures seem to be realted to 7.x but on master-related PRs there are also strange failures. |
💔 Build Failed |
|
Jenkins, test this. |
💔 Build Failed |
💚 Build Succeeded |
jbudz
added
release_note:skip
jbudz
approved these changes
Nov 12, 2019
jbudz
pushed a commit
that referenced
this pull request
Nov 12, 2019
* deprecate include_type_name * include_type_name * remove doc from mappings * Updated timelion mapping * Updated spaces and uptime mapping * monitoring apm mapping * Updated more mappings * 2 more mappings * Updated reporting mappings after syncing with @gammon * Revert "update chromedriver dependency to v78 (#49737)" This reverts commit 4a696b9.
jbudz
pushed a commit
that referenced
this pull request
Nov 12, 2019
* deprecate include_type_name * include_type_name * remove doc from mappings * Updated timelion mapping * Updated spaces and uptime mapping * monitoring apm mapping * Updated more mappings * 2 more mappings * Updated reporting mappings after syncing with @gammon * Revert "update chromedriver dependency to v78 (#49737)" This reverts commit 4a696b9.
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Nov 13, 2019
This reverts commit a0ff933.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Nov 13, 2019
* deprecate include_type_name * include_type_name * remove doc from mappings * Updated timelion mapping * Updated spaces and uptime mapping * monitoring apm mapping * Updated more mappings * 2 more mappings * Updated reporting mappings after syncing with @gammon * Revert "update chromedriver dependency to v78 (elastic#49737)" This reverts commit 4a696b9.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 13, 2019
* upstream/master: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120)
This was referenced Nov 14, 2019
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 14, 2019
* deprecate include_type_name * include_type_name * remove doc from mappings * Updated timelion mapping * Updated spaces and uptime mapping * monitoring apm mapping * Updated more mappings * 2 more mappings * Updated reporting mappings after syncing with @gammon * Revert "update chromedriver dependency to v78 (elastic#49737)" This reverts commit 4a696b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a test whether this fails the tests.
Last week a chromedriver update got merged in and now there are some tests flaky on 7.5 and 7.x and also sometimes in master: https://github.com/elastic/kibana/issues?q=is%3Aopen+is%3Aissue+assignee%3Aflash1293+label%3Afailed-test
This PR is here to test whether those failures are caused by the update. If this is the case, the update should be reverted on all branches.