Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BRAZIL to maps panel #508

Closed
wants to merge 1 commit into from
Closed

Added BRAZIL to maps panel #508

wants to merge 1 commit into from

Conversation

cdonke
Copy link

@cdonke cdonke commented Sep 17, 2013

No description provided.

@rashidkpc
Copy link
Contributor

This is a very very large map. Larger than I think we want to include. Currently our world map weighs in at just 144k, this is 1125k. We're going to hold on adding new maps for now until we come up with a better method of communicating valid region names.

@rashidkpc rashidkpc closed this Sep 19, 2013
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
Added masterLicenseID to License protobuffer.
w33ble added a commit to w33ble/kibana that referenced this pull request Sep 13, 2018
* fix: pass correct dataurl with empty value

check the length of the dataurl string, pass the default logo if it's 0

* chore: consolidate image dataurl code

the logic is the same, move code into a helper

* fix: use correct output for image functions

when provided with missing images, return the defaults from the functions

* chore: remove lodash.map use

* chore: remove recompose lifecycle from FunctionForm

makes code easier to understand. also make all the props being passed into expression render functions explicit, and use propTypes

* feat: provide an arg resolver helper

useful for getting the resolved value of an argument, from a subexpression for example. automatically provides the correct context for the argument

* chore: stricter proptypes on arg_form

* feat: add arg resolve flag to arg types

this informs the application that arg values should be resolved and the resolved value passed to the template

* feat: handle arg types that need to be resolved

check the value and resolveArgs prop, render a loading compomnent that fires off the resolution if required

* chore: add image preview to upload form

support based on the resolved arg value, with some base type and value
checking

* chore: enhance loading component

use it image upload and argument resolution

* fix: bring back the arg type tooltips

* chore: rename resolveArgs to resolveArgValue

* fix: swallow argResolver errors

they aren't important. worst case, the resolved value won't be available, and consumers should be checking the value anyway

* chore: change arg value resolution loading text

* feat: use missing asset for invalid dataurls

* fix: classnames on several components

* fix: load form with unresolved arg values

* fix: only show missing asset when value is not null

* fix: parse svg dataurls correctly

and use test instead of match for isValid check

* fix: correctly resolve with missing image placeholder

* fix: default empty images to null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants