Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query String(Bar) Input - cleanup #51598

Merged
merged 10 commits into from
Nov 27, 2019
Merged

Query String(Bar) Input - cleanup #51598

merged 10 commits into from
Nov 27, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Nov 25, 2019 •
edited
Loading

Summary

Part of #51023

  • Rename QueryBarInput to QueryStringInput
  • Moved typeahead to ui/typeahead
  • Use IIndexPattern

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom self-assigned this Nov 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom mentioned this pull request Nov 25, 2019
Closed
3 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

Liza K added 3 commits November 25, 2019 17:59
Moved Suggestions to NP
a8f2cc9 
Renamed QueryBarInput to QueryStringInput
Changed IndexPattern to IIndexPattern
fix import
6040347
Update snapshot
99d026c
@lizozom lizozom force-pushed the newplatform/query-string-input/cleanup branch from 0f12b53 to 99d026c Compare November 25, 2019 15:59
@lizozom lizozom marked this pull request as ready for review November 25, 2019 16:00
@lizozom lizozom requested a review from a team November 25, 2019 16:00
@lizozom lizozom requested review from a team as code owners November 25, 2019 16:00
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

cchaos
cchaos suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that the old import of the query_bar/components/typeahead/_index.scss is now broken somewhere as I'm not seeing an import change to ui/typeahead/_index.scss

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Nov 25, 2019

@cchaos fixed

@lizozom
Copy link
Contributor Author

lizozom commented Nov 25, 2019

@elastic/kibana-platform migration.md changes
@elastic/kibana-app import changes

cchaos
cchaos approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Nov 26, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Nov 26, 2019

retest

@lizozom lizozom force-pushed the newplatform/query-string-input/cleanup branch from 51781a4 to 0e8f680 Compare November 26, 2019 09:53
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

kertal
kertal reviewed Nov 26, 2019
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

@kertal kertal self-requested a review November 26, 2019 11:25
kertal
kertal approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and now I've pressed the right button

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom force-pushed the newplatform/query-string-input/cleanup branch from 70aea61 to 3cfb98c Compare November 27, 2019 09:29
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 8797e68 into elastic:master Nov 27, 2019
@lizozom lizozom mentioned this pull request Nov 27, 2019
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Nov 27, 2019
Query String(Bar) Input - cleanup (elastic#51598)
057e93b 
* Moved Suggestions to NP
Renamed QueryBarInput to QueryStringInput
Changed IndexPattern to IIndexPattern

* fix import

* Update snapshot

* css import

* scss

* eslint
lizozom pushed a commit that referenced this pull request Nov 27, 2019
Query String(Bar) Input - cleanup (#51598) (#51804)
c2ba9d1 
* Moved Suggestions to NP
Renamed QueryBarInput to QueryStringInput
Changed IndexPattern to IIndexPattern

* fix import

* Update snapshot

* css import

* scss

* eslint
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 27, 2019
@jloleysens
Merge remote-tracking branch 'upstream/7.x' into backport/7.x/pr-50163
bc6197f 
* upstream/7.x:
  Fix infinite redirect loop when multiple cookies are sent (elastic#50452) (elastic#51821)
  [Console] Proxy fallback (elastic#50185) (elastic#51814)
  Added endgame-* index and new heading 3 Elastic Endpoint SMP. (elastic#51071) (elastic#51828)
  [Maps] Added options to disable zoom, hide tool tips, widgets/overlays in embeddable maps (elastic#50663) (elastic#51811)
  Move errors and validate index pattern ⇒ NP (elastic#51805) (elastic#51831)
  [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) (elastic#51827)
  [Lens] Remove client-side reference to server source code (elastic#51763) (elastic#51825)
  fixes drag and drop in tests (elastic#51806) (elastic#51813)
  [Uptime] Redesign/44541  new monitor list expanded row (elastic#46567) (elastic#51809)
  [7.x] [Telemetry] collector set to np (elastic#51618) (elastic#51787)
  [Uptime] added test for chart wrapper (elastic#50399) (elastic#51808)
  Expressions service fixes: better error and loading states handling (elastic#51183) (elastic#51800)
  Query String(Bar) Input - cleanup (elastic#51598) (elastic#51804)
  [ML] Adjust and re-enable categorization advanced wizard test (elastic#51005) (elastic#51017)
  fixes url state tests (elastic#51746) (elastic#51798)
  fixes browser field tests (elastic#51738) (elastic#51799)
  [Task Manager] Tests for the ability to run tasks of varying durations in parallel (elastic#51572) (elastic#51701)
  [ML] Fix anomaly detection test suite (elastic#51712) (elastic#51795)
  [SIEM] Fix Timeline drag and drop behavior (elastic#51558) (elastic#51793)
mbondyra added a commit to mbondyra/kibana that referenced this pull request Nov 28, 2019
@mbondyra
Merge branch 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondy…
4b0ac16 
…ra/kibana into IS-46410_remove-@kbn/ui-framework

* 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondyra/kibana: (49 commits)
  [ML] Re-activate after method in transform test (elastic#51815)
  [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670)
  De-angularize visLegend (elastic#50613)
  [SIEM][Detection Engine] Change security model to use SIEM permissions
  [Monitoring] Sass cleanup (elastic#51100)
  Move errors and validate index pattern ⇒ NP (elastic#51805)
  fixes pagination tests (elastic#51822)
  Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882)
  [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782)
  [Lens] Remove client-side reference to server source code (elastic#51763)
  Fix infinite redirect loop when multiple cookies are sent (elastic#50452)
  fixes drag and drop in tests (elastic#51806)
  [Console] Proxy fallback (elastic#50185)
  Query String(Bar) Input - cleanup (elastic#51598)
  shim visualizations plugin (elastic#50624)
  Expressions service fixes: better error and loading states handling (elastic#51183)
  fixes url state tests (elastic#51746)
  fixes browser field tests (elastic#51738)
  [ML] Fix anomaly detection test suite (elastic#51712)
  [SIEM] Fix Timeline drag and drop behavior (elastic#51558)
  ...
timductive pushed a commit to timductive/kibana that referenced this pull request Dec 16, 2019
@timductive
Query String(Bar) Input - cleanup (elastic#51598)
80f342e 
* Moved Suggestions to NP
Renamed QueryBarInput to QueryStringInput
Changed IndexPattern to IIndexPattern

* fix import

* Update snapshot

* css import

* scss

* eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@cchaos cchaos cchaos approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lizozom @elasticmachine @kertal @cchaos @pgayvallet @lukeelmers