Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Feature/expandable row in details ping list #51890

Merged
merged 8 commits into from
Dec 10, 2019
Merged

[Uptime] Feature/expandable row in details ping list #51890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
090ab87
update columns
shahzad31 Nov 28, 2019
80e27b5
Merge branch 'master' into feature/monit-details-view-avoid-empty-column
shahzad31 Nov 28, 2019
51b2021
update expand row in ping list
shahzad31 Nov 28, 2019
feb1db8
Merge branch 'master' into feature/expandable-row-in-details-ping-list
shahzad31 Dec 2, 2019
00cadb7
Merge branch 'master' into feature/expandable-row-in-details-ping-list
elasticmachine Dec 5, 2019
6be5bc9
Merge branch 'master' into feature/expandable-row-in-details-ping-list
shahzad31 Dec 6, 2019
443c4b1
Merge branch 'master' into feature/expandable-row-in-details-ping-list
shahzad31 Dec 6, 2019
ee1f8b0
Merge branch 'master' into feature/expandable-row-in-details-ping-list
elasticmachine Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...lic/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...nts/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export const MonitorListComponent = (props: Props) => {
field: 'monitor_id',
name: '',
sortable: true,
width: '40px',
width: '24px',
isExpander: true,
render: (id: string) => {
return (
Expand Down
6 changes: 4 additions & 2 deletions ...me/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export const PingListComponent = ({
if (hasStatus) {
columns.push({
field: 'http.response.status_code',
align: 'right',
align: 'center',
name: i18n.translate('xpack.uptime.pingList.responseCodeColumnLabel', {
defaultMessage: 'Response code',
}),
Expand All @@ -200,7 +200,7 @@ export const PingListComponent = ({

columns.push({
align: 'right',
width: '40px',
width: '24px',
isExpander: true,
render: (item: Ping) => (
<EuiButtonIcon
Expand Down Expand Up @@ -300,6 +300,8 @@ export const PingListComponent = ({
<EuiBasicTable
loading={loading}
columns={columns}
isExpandable={true}
hasActions={true}
items={pings}
itemId="id"
itemIdToExpandedRowMap={itemIdToExpandedRowMap}
Expand Down