Add top level examples folder and command to run, `--run-examples`. #52027

stacey-gammon · 2019-12-02T21:43:13Z

Fixes #26781

Adds a top level examples folder filled with example plugins that can be run with a --run-examples flag. Currently the only two plugins in there are:
- Demo search - a plugin that registers a new custom search strategy
- Search explorer - an app that shows/tests how both the demo search strategy, and the already registered es search strategy, can be used to search for data.
Creates a new functional test folder that has tests for the examples. I pulled this out from the plugin_functional folder so it could use the --run-examples flag in the config.

Blocks #52111

elasticmachine · 2019-12-02T21:58:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ed86c9e

elasticmachine · 2019-12-03T17:17:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 3badfa2

elasticmachine · 2019-12-03T17:45:20Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: c29adca

elasticmachine · 2019-12-03T17:57:37Z

Pinging @elastic/kibana-platform (Team:Platform)

elasticmachine · 2019-12-03T18:02:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 4c199f0

elasticmachine · 2019-12-03T19:54:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: b8a0215

elasticmachine · 2019-12-03T21:14:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 52c2bd1

elasticmachine · 2019-12-03T22:50:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f3c54d4

…n-demos-shortcuts

elasticmachine · 2019-12-04T15:11:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f0b78de

joshdover · 2019-12-10T00:28:09Z

src/cli/serve/serve.js

@@ -237,7 +243,7 @@ export default function (program) {
          silent: !!opts.silent,
          watch: !!opts.watch,
          repl: !!opts.repl,
-          basePath: !!opts.basePath,
+          basePath: opts.runExamples ? false : !!opts.basePath,


What's the reason for this?

Good question. Added an explanation. Copying here:

// We want to run without base path when the `--run-examples` flag is given so that we can use local // links in other documentation sources, like "View this tutorial [here](http://localhost:5601/app/tutorial/xyz)". // We can tell users they only have to run with `yarn start --run-examples` to get those // local links to work. Similar to what we do for "View in Console" links in our // elastic.co links.

stacey-gammon · 2019-12-10T19:07:42Z

@elasticmachine merge upstream

…n-demos-shortcuts

…mmon/kibana into 2019-11-25-run-demos-shortcuts

elasticmachine · 2019-12-10T21:20:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1513ff8

History

💚 Build #14613 succeeded eac6f6b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tylersmalley

LGTM, tested

…le-sql-highlighting * 'master' of github.com:elastic/kibana: (56 commits) Migrate url shortener service (elastic#50896) Re-enable datemath in from/to canvas timelion args (elastic#52159) [Logs + Metrics UI] Remove eslint exceptions (elastic#50979) [Logs + Metrics UI] Add missing headers in Logs & metrics (elastic#52405) [ML] API integration tests - initial tests for bucket span estimator (elastic#52636) [Watcher] New Platform (NP) Migration (elastic#50908) Decouple Authorization subsystem from Legacy API. (elastic#52638) [APM] Fix some warnings logged in APM tests (elastic#52487) [ui/public/utils] Delete unused base_object & find_by_param (elastic#52500) [ui/public/utils] Move items into ui/vis (elastic#52615) fix newlines in kbn-analytics build script Add top level examples folder and command to run, `--run-examples`. (elastic#52027) feat(NA): add trap for SIGINT in the git precommit hook (elastic#52662) [DOCS] Updtes description of elasticsearch.requestHeadersWhitelist (elastic#52675) [Telemetry/Pulse] Updates advanced settings text for usage data (elastic#52657) [SIEM][Detection Engine] Adds the default name space to the end of the signals index [Logs UI] Generalize ML module management (elastic#50662) Removing stateful saved object finder (elastic#52166) Shim oss telemetry (elastic#51168) [Reporting/Screenshots] Do not fail the report if request is aborted (elastic#52344) ... # Conflicts: # src/legacy/core_plugins/console/public/legacy.ts # src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/mode/elasticsearch_sql_highlight_rules.ts # src/legacy/core_plugins/console/public/np_ready/lib/autocomplete/components/full_request_component.ts # src/legacy/core_plugins/console/public/quarantined/src/sense_editor/row_parser.js

…lastic#52027) * Add top level examples folder and command to run, `--run-examples`. * Add comment explaining reason --run-examples flag turns off base path.

…52027) (#52739) * Add top level examples folder and command to run, `--run-examples`. * Add comment explaining reason --run-examples flag turns off base path.

…lastic#52027) * Add top level examples folder and command to run, `--run-examples`. * Add comment explaining reason --run-examples flag turns off base path.

stacey-gammon force-pushed the 2019-11-25-run-demos-shortcuts branch from ed86c9e to 3badfa2 Compare December 3, 2019 17:07

stacey-gammon force-pushed the 2019-11-25-run-demos-shortcuts branch 2 times, most recently from 4c31ad4 to c29adca Compare December 3, 2019 17:34

stacey-gammon force-pushed the 2019-11-25-run-demos-shortcuts branch 2 times, most recently from d247678 to 4c199f0 Compare December 3, 2019 17:52

stacey-gammon added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Dec 3, 2019

stacey-gammon requested a review from tylersmalley December 3, 2019 17:56

stacey-gammon force-pushed the 2019-11-25-run-demos-shortcuts branch 2 times, most recently from fe4c89d to 96754d6 Compare December 3, 2019 18:11

stacey-gammon mentioned this pull request Dec 3, 2019

add new --run-examples flag #52031

Closed

stacey-gammon marked this pull request as ready for review December 3, 2019 18:34

stacey-gammon requested a review from a team as a code owner December 3, 2019 18:34

stacey-gammon force-pushed the 2019-11-25-run-demos-shortcuts branch from 96754d6 to b8a0215 Compare December 3, 2019 18:40

stacey-gammon force-pushed the 2019-11-25-run-demos-shortcuts branch from b8a0215 to 52c2bd1 Compare December 3, 2019 19:57

Add top level examples folder and command to run, --run-examples.

f3c54d4

stacey-gammon force-pushed the 2019-11-25-run-demos-shortcuts branch from 52c2bd1 to f3c54d4 Compare December 3, 2019 21:30

stacey-gammon mentioned this pull request Dec 3, 2019

Embeddable examples on the platform and included with --run-examples flag #52111

Merged

stacey-gammon added the review label Dec 3, 2019

stacey-gammon requested a review from joshdover December 3, 2019 22:53

Merge branch 'master' of github.com:elastic/kibana into 2019-11-25-ru…

f0b78de

…n-demos-shortcuts

stacey-gammon requested a review from lizozom December 4, 2019 18:13

joshdover approved these changes Dec 10, 2019

View reviewed changes

elasticmachine and others added 4 commits December 10, 2019 11:07

Merge branch 'master' into 2019-11-25-run-demos-shortcuts

eac6f6b

Merge branch 'master' of github.com:elastic/kibana into 2019-11-25-ru…

4438615

…n-demos-shortcuts

Merge branch '2019-11-25-run-demos-shortcuts' of github.com:stacey-ga…

1012e72

…mmon/kibana into 2019-11-25-run-demos-shortcuts

Add comment explaining reason --run-examples flag turns off base path.

1513ff8

tylersmalley approved these changes Dec 10, 2019

View reviewed changes

stacey-gammon merged commit 79fc07c into elastic:master Dec 10, 2019

stacey-gammon mentioned this pull request Dec 11, 2019

[7.x] Add top level examples folder and command to run, --run-examples. (#52027) #52739

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add top level examples folder and command to run, `--run-examples`. #52027

Add top level examples folder and command to run, `--run-examples`. #52027

stacey-gammon commented Dec 2, 2019 •

edited by tylersmalley

Loading

elasticmachine commented Dec 2, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 4, 2019

joshdover Dec 10, 2019

stacey-gammon Dec 10, 2019

stacey-gammon commented Dec 10, 2019

elasticmachine commented Dec 10, 2019

tylersmalley left a comment

Add top level examples folder and command to run, --run-examples. #52027

Add top level examples folder and command to run, --run-examples. #52027

Conversation

stacey-gammon commented Dec 2, 2019 • edited by tylersmalley Loading

elasticmachine commented Dec 2, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

💚 Build Succeeded

elasticmachine commented Dec 4, 2019

💚 Build Succeeded

joshdover Dec 10, 2019

Choose a reason for hiding this comment

stacey-gammon Dec 10, 2019

Choose a reason for hiding this comment

stacey-gammon commented Dec 10, 2019

elasticmachine commented Dec 10, 2019

💚 Build Succeeded

History

tylersmalley left a comment

Choose a reason for hiding this comment

Add top level examples folder and command to run, `--run-examples`. #52027

Add top level examples folder and command to run, `--run-examples`. #52027

stacey-gammon commented Dec 2, 2019 •

edited by tylersmalley

Loading