[Vis] Move Timelion Vis to vis_type_timelion

[maryia-lapata]

Summary

Moving Timelion Vis to a separate plugin vis_type_timelion.
Converting chart code to React.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• [ ] This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• [ ] This was checked for breaking API changes and was labeled appropriately
• [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

[maryia-lapata]

@elasticmachine merge upstream

[cchaos]

Thanks for those SASS changes 👍

[flash1293]

Looks like this type isn't correct - this is what the API returns:

[maryia-lapata]

But according to this code

kibana/src/legacy/core_plugins/timelion/public/directives/chart/chart.js

Line 39 in 41601ff

$scope.seriesList.render = $scope.seriesList.render || {

the API can return render too, or it will be set by default. Yeah, render definitely should be an optional property.

[maryia-lapata]

Okay, after resolving this #52069 (comment) we don't need type from render, but grid property is still used

kibana/src/legacy/core_plugins/timelion/public/panels/timechart/schema.ts

Line 84 in 41601ff

show: render.grid,

[flash1293]

@maryia-lapata Answered to some of the comment threads. Best look through the comments starting from #52069 (review)

[maryia-lapata]

@elasticmachine merge upstream

[maryia-lapata]

I disabled TS here because transform accepts accumulator as an array, but in this case an object used. And to show the real types (Values) I had to disable TS.

[flash1293]

Using transform is unnecessary here, this code is just iterating over the static input array and is putting stuff into an object. You can also write it like this:

const unitMappings = [
  ['ms', 'milliseconds', 'millisecond'],
  ['s', 'seconds', 'second', 'sec'],
  ['m', 'minutes', 'minute', 'min'],
  ['h', 'hours', 'hour'],
  ['d', 'days', 'day'],
  ['w', 'weeks', 'week'],
  ['M', 'months', 'month'],
  ['quarter'],
  ['y', 'years', 'year'],
] as Units[][];
const vals = {} as Values;
unitMappings.forEach(units => {
  const normal = moment.normalizeUnits(units[0]) as Units;
  const val = moment.duration(1, normal).asMilliseconds();
  ([] as Units[]).concat(normal, units).forEach((unit: Units) => {
    vals[unit] = val;
  });
});

[flash1293]

LGTM, didn't find anything else 👍 Tested in Chrome

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f7a95e1

History

• 💚 Build #21028 succeeded 99ecd4a
• 💚 Build #20755 succeeded 07c5582
• 💚 Build #20632 succeeded c34477c
• 💚 Build #20584 succeeded a30016f
• 💚 Build #20136 succeeded 4842db3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)