[kbnClient] Retry uiSettings.replace() calls up to 5 times #52601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 9, 2019 19:32
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
brianseeders
approved these changes
Dec 11, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 11, 2019
…2601) * [kbn/dev-utils] target ES2019 to transpile ?? * Retry uiSettings.replace() calls up to 5 times * share logic for selecting junit report name to ensure they are unique * convert to junit report path helper # Conflicts: # src/dev/jest/junit_reporter.js
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 11, 2019
…2601) * [kbn/dev-utils] target ES2019 to transpile ?? * Retry uiSettings.replace() calls up to 5 times * share logic for selecting junit report name to ensure they are unique * convert to junit report path helper # Conflicts: # packages/kbn-test/src/mocha/__tests__/junit_report_generation.js # packages/kbn-test/src/mocha/junit_report_generation.js # src/dev/jest/junit_reporter.js
This was referenced Dec 11, 2019
Merged
spalger
pushed a commit
that referenced
this pull request
Dec 12, 2019
* [kbnClient] Retry uiSettings.replace() calls up to 5 times (#52601) * [kbn/dev-utils] target ES2019 to transpile ?? * Retry uiSettings.replace() calls up to 5 times * share logic for selecting junit report name to ensure they are unique * convert to junit report path helper # Conflicts: # packages/kbn-test/src/mocha/__tests__/junit_report_generation.js # packages/kbn-test/src/mocha/junit_report_generation.js # src/dev/jest/junit_reporter.js * remove ?? syntax * fix more null-ish syntax not supported in 7.5 * fix imports
timductive
pushed a commit
to timductive/kibana
that referenced
this pull request
Dec 16, 2019
…2601) * [kbn/dev-utils] target ES2019 to transpile ?? * Retry uiSettings.replace() calls up to 5 times * share logic for selecting junit report name to ensure they are unique * convert to junit report path helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51038
This fixes failures caused by conflicts when replacing the uiSettings document, to avoid this we should retry the call to
kbnClient.uiSettings.replace()up to five times. We do this automatically since we don't actually care about the current values, we want to overwrite all of them.