Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Remove angular field filter template code #53513

Merged
merged 2 commits into from
Dec 19, 2019
Merged

[Discover] Remove angular field filter template code #53513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88c9c25
Remove angular field filter code
kertal Dec 18, 2019
b01a361
Fix translations
kertal Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions src/legacy/core_plugins/kibana/public/discover/components/field_chooser/field_chooser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,64 +13,6 @@
types="fieldTypes"
>
</discover-field-search>
<div data-test-subj="discoverFieldFilter" class="dscFieldFilter" ng-show="showFilter">
<div class="form-group" >
<label
for="discoverFieldChooserFilterAggregatable"
i18n-id="kbn.discover.fieldChooser.filter.aggregatableLabel"
i18n-default-message="Aggregatable"
></label>
<select
id="discoverFieldChooserFilterAggregatable"
ng-options="opt.value as opt.label for opt in filter.boolOpts"
ng-model="filter.vals.aggregatable"
class="form-control">
</select>
</div>
<div class="form-group" ng-show="showFilter">
<label
for="discoverFieldChooserFilterSearchable"
i18n-id="kbn.discover.fieldChooser.filter.searchableLabel"
i18n-default-message="Searchable"
></label>
<select
id="discoverFieldChooserFilterSearchable"
ng-options="opt.value as opt.label for opt in filter.boolOpts"
ng-model="filter.vals.searchable"
class="form-control">
</select>
</div>
<div class="form-group" ng-show="showFilter">
<label
for="discoverFieldChooserFilterType"
i18n-id="kbn.discover.fieldChooser.filter.typeLabel"
i18n-default-message="Type"
></label>
<select
id="discoverFieldChooserFilterType"
ng-options="field as field for field in fieldTypes"
ng-model="filter.vals.type"
class="form-control">
</select>
</div>
<div class="form-group" ng-show="showFilter">
<label for="discoverFieldChooserHideMissingFields">
<input id="discoverFieldChooserHideMissingFields" type="checkbox" ng-model="filter.vals.missing">
<span
i18n-id="kbn.discover.fieldChooser.filter.hideMissingFieldsLabel"
i18n-default-message="Hide missing fields"
></span>
</label>
</div>
<button
ng-show="showFilter"
ng-click="filter.reset()"
ng-disabled="!filter.active"
class="kuiButton kuiButton--danger kuiButton--fullWidth"
i18n-id="kbn.discover.fieldChooser.filter.resetFiltersButtonLabel"
i18n-default-message="Reset filters"
></button>
</div>
</form>
</div>

Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,7 +1551,6 @@
"kbn.discover.fieldChooser.filter.hideMissingFieldsLabel": "未入力のフィールドを非表示",
"kbn.discover.fieldChooser.filter.indexAndFieldsSectionAriaLabel": "インデックスとフィールド",
"kbn.discover.fieldChooser.filter.popularTitle": "人気",
"kbn.discover.fieldChooser.filter.resetFiltersButtonLabel": "フィルターをリセット",
"kbn.discover.fieldChooser.filter.searchableLabel": "検索可能",
"kbn.discover.fieldChooser.filter.selectedFieldsTitle": "スクリプトフィールド",
"kbn.discover.fieldChooser.filter.typeLabel": "タイプ",
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1552,7 +1552,6 @@
"kbn.discover.fieldChooser.filter.hideMissingFieldsLabel": "隐藏缺失字段",
"kbn.discover.fieldChooser.filter.indexAndFieldsSectionAriaLabel": "索引和字段",
"kbn.discover.fieldChooser.filter.popularTitle": "常用",
"kbn.discover.fieldChooser.filter.resetFiltersButtonLabel": "重置筛选",
Copy link
Contributor

@majagrubic majagrubic Dec 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, just thinking about this... this is one thing I omitted in my original PR, mostly because Lens doesn't have it. Should we add this option as well? Definitely not a blocker for this PR, just thinking it might be worth adding a backlog item if needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A backlog item to discuss is a good idea! thx!

"kbn.discover.fieldChooser.filter.searchableLabel": "可搜索",
"kbn.discover.fieldChooser.filter.selectedFieldsTitle": "选定字段",
"kbn.discover.fieldChooser.filter.typeLabel": "类型",
Expand Down Expand Up @@ -12810,4 +12809,4 @@
"xpack.licensing.welcomeBanner.licenseIsExpiredDescription.updateYourLicenseLinkText": "更新您的许可",
"xpack.licensing.welcomeBanner.licenseIsExpiredTitle": "您的{licenseType}许可已过期"
}
}
}