[SIEM] Improves event viewer Cypress tests time execution #54117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
MadameSheema
requested review from
andrew-goldstein,
patrykkopycinski and
stephmilovic
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
approved these changes
Jan 7, 2020
|
|
||
| filterSearchBar(filterInput); | ||
| beforeEach(() => { |
andrew-goldstein
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Per our out-of-band team discussion, the team agrees to adopt the new patterns introduced in this PR:
- To reduce the overall time it takes to execute the test suite, full page refreshes will no longer be performed (to reset state) before each test (
itblock) executes - Instead, tests within a
context, will login and navigate to the page under test just once. - Within a
context, reset state (e.g. "close the modal") in anafterEach. When designing your tests, carefully consider whether or not the cleanup code in theafterEachis sufficient to fully reset state if/when a previous test fails at an arbitrary step. - All tests in a
.specmust (as usual), remain order-independent. (Sometimes, it may be necessary to create a newcontextand perform a full page refresh to ensure this.)
To test this PR, I ran the Events Viewer test suite locally:
LGTM ⌛️ 🚀
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
MadameSheema
added a commit
that referenced
this pull request
Jan 10, 2020
…54444) * groups tests in context * makes tests fully order-independent * updates Readme file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the Events Viewer tests time execution from 172s to 94s grouping the tests by context.
In most cases we don't need to login to the application all the time since most of the tests it can be seen as different checks of a same test.