Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Empty dashboard screen #55727

Merged
merged 3 commits into from
Jan 27, 2020

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Jan 23, 2020

Summary

Added the docs for:

[skip ci]

You can view the docs here.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@KOTungseth KOTungseth added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.6.0 labels Jan 23, 2020
@KOTungseth KOTungseth self-assigned this Jan 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@KOTungseth KOTungseth requested a review from a team January 23, 2020 16:45
docs/user/dashboard.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard.asciidoc Show resolved Hide resolved
docs/user/dashboard.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard.asciidoc Outdated Show resolved Hide resolved
@@ -137,26 +152,21 @@ tools. To create a short URL, you must have write access to {kib}.
=== Import and export dashboards

To import and export dashboards, go to *Management > Saved Objects*. For details,
see <<managing-saved-objects, Managing saved objects>>.
see <<managing-saved-objects, Managing saved objects>>.

[float]
[[viewing-detailed-information]]
=== Inspect and edit elements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section feels like it belongs on a separate page. Also, it needs more information about why you would want to inspect and edit an element. Maybe a separate PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm moving this section up. I inspect/edit elements as I'm arranging them on the dashboard, and I definitely do this before I save the dashboard.

docs/user/dashboard.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KOTungseth KOTungseth merged commit 17011b7 into elastic:master Jan 27, 2020
@KOTungseth KOTungseth deleted the docs/dashboard-first branch January 27, 2020 17:33
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Jan 27, 2020
* [DOCS] AdEmpty dashboard screen redesign

* Review comments f from Gail

* Comments from Gaiail pt 2
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Jan 27, 2020
* [DOCS] AdEmpty dashboard screen redesign

* Review comments f from Gail

* Comments from Gaiail pt 2
KOTungseth added a commit that referenced this pull request Jan 27, 2020
* [DOCS] AdEmpty dashboard screen redesign

* Review comments f from Gail

* Comments from Gaiail pt 2
KOTungseth added a commit that referenced this pull request Jan 27, 2020
* [DOCS] AdEmpty dashboard screen redesign

* Review comments f from Gail

* Comments from Gaiail pt 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.6.0 v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants