[Canvas] Use unique Id for Canvas Embeddables #56783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
release_note:skip
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
crob611
added
the
impact:low
💚 Build SucceededTo update your PR or re-run it, just comment with: |
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Feb 4, 2020
* Use uniqueID for embeddable registry * Adds type to renderer
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Feb 4, 2020
* Use uniqueID for embeddable registry * Adds type to renderer
crob611
pushed a commit
that referenced
this pull request
Feb 5, 2020
crob611
pushed a commit
that referenced
this pull request
Feb 5, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 5, 2020
* master: (23 commits) Properly handle password change for users authenticated with provider other than `basic`. (elastic#55206) Improve pull request template proposal (elastic#56756) Only change handlers as the element changes (elastic#56782) [SIEM][Detection Engine] Final final rule changes (elastic#56806) [SIEM][Detection Engine] critical blocker, wrong ilm policy, need to match beats ilm policy Move ui/agg_types in to shim data plugin (elastic#56353) [SIEM] Fixes Signals count spinner (elastic#56797) [docs] Update upgrade version path (elastic#56658) [Canvas] Use unique Id for Canvas Embeddables (elastic#56783) [Rollups] Adjust max width for job detail panel (elastic#56674) Prevent http client from converting our form data (elastic#56772) Disable creating alerts client instances when ESO plugin is using an ephemeral encryption key (elastic#56676) Bumps terser-webpack-plugin to 2.3.4 (elastic#56662) Advanced settings component registry ⇒ kibana platform plugin (elastic#55940) [Endpoint] EMT-67: add kql support for endpoint list (elastic#56328) Implement UI for Create Alert form (elastic#55232) Fix: Filter pill base coloring (elastic#56761) fix open close signal on detail page (elastic#56757) [Search service] Move loadingCount to sync search strategy (elastic#56335) Rollup TSVB integration: Add test and fix warning text (elastic#56639) ...
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 10, 2020
* Use uniqueID for embeddable registry * Adds type to renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #56663
When rendering an embeddable in canvas, the renderer keeps a registry of all of the embeddable objects so it doesn't have to reload + refetch on every render. This registry was keyed by the embeddables ID, but this was causing problems if the same embeddable was embedded more than once.
This adds a way for a renderer to access the element ID, so it can use that as a unique key during the render if needed.