Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default columns configurable #5696

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Make default columns configurable #5696

merged 1 commit into from
Mar 7, 2016

Conversation

vquemener
Copy link
Contributor

Closes #2964.

Add a variable to set the columns displayed by default in the "Discover" tab.

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@rashidkpc
Copy link
Contributor

I like the idea here, but the implementation isn't right. The doc_table is a directive with an isolate scope. You should be changing what you pass into that.

See this line: https://github.com/elastic/kibana/blob/master/src/plugins/kibana/public/discover/controllers/discover.js#L120

@vquemener
Copy link
Contributor Author

OK, I gave it another shot: I removed the code from the doc_table, and injected my variable into the line you pointed me to. Is that better now?

@mediocregopher
Copy link

+1 would love to see this implemented

@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

jenkins, test it

@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

This needs to be rebased on master or have master merged into it.

@vquemener
Copy link
Contributor Author

Done.

@epixa
Copy link
Contributor

epixa commented Feb 9, 2016

jenkins, test it

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

rashidkpc pushed a commit that referenced this pull request Mar 7, 2016
Make default columns configurable
@rashidkpc rashidkpc merged commit 320fef3 into elastic:master Mar 7, 2016
@epixa epixa added the v5.0.0 label Mar 7, 2016
@dfaropennetwork
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants