[Uptime] Fix/host connected components #56969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
added
release_note:skip
| isApmAvailable={true} | ||
| isInfraAvailable={false} | ||
| isLogsAvailable={true} | ||
| // basePath="foo" |
There was a problem hiding this comment.
Delete this code if it's not longer needed.
| isApmAvailable={true} | ||
| isInfraAvailable={true} | ||
| isLogsAvailable={false} | ||
| // basePath="foo" |
There was a problem hiding this comment.
Ditto to deleting the code.
| @@ -0,0 +1,21 @@ | |||
| /* | |||
There was a problem hiding this comment.
Let's delete this file as we have ./helper_with_router.ts in this same directory now.
There was a problem hiding this comment.
must have messed up during conflicts.
| @@ -100,7 +100,7 @@ const Application = (props: UptimeAppProps) => { | |||
| <EuiPage className="app-wrapper-panel " data-test-subj="uptimeApp"> | |||
| <main> | |||
| <PageHeader setBreadcrumbs={setBreadcrumbs} /> | |||
| // @ts-ignore we need to update the type of this prop | |||
| {/* @ts-ignore we need to update the type of this prop*/} | |||
There was a problem hiding this comment.
Suggested change
| {/* @ts-ignore we need to update the type of this prop*/} | |
| {/* @ts-ignore TODO we need to update the type of this prop*/} |
While we're here, let's put a TODO string in there so if someone is searching for TODOs this will show up.
|
@justinkambic took care of your feedback |
shahzad31
changed the title
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
justinkambic
approved these changes
Feb 13, 2020
| @@ -100,7 +100,6 @@ const Application = (props: UptimeAppProps) => { | |||
| <EuiPage className="app-wrapper-panel " data-test-subj="uptimeApp"> | |||
| <main> | |||
| <PageHeader setBreadcrumbs={setBreadcrumbs} /> | |||
| // @ts-ignore we need to update the type of this prop | |||
There was a problem hiding this comment.
Being able to delete it, even better!
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Feb 14, 2020
* added test for pages * fixed types * moved redux logic to connected * comment * update type * type fix
shahzad31
added a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix elastic/uptime#134
Move containers into connected folder.