Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NA): MaxListenersExceededWarning on getLoggerStream #57133

Merged
merged 5 commits into from
Feb 10, 2020
Merged

fix(NA): MaxListenersExceededWarning on getLoggerStream #57133

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd7606d
fix(NA): possible EventEmitter memory leak detected with a passthroug…
mistic Feb 7, 2020
8d6359a
Merge branch 'master' into fix-log-reporter-max-listeners
elasticmachine Feb 7, 2020
4ff0366
Merge branch 'master' into fix-log-reporter-max-listeners
mistic Feb 10, 2020
8229e14
Merge branch 'fix-log-reporter-max-listeners' of github.com:mistic/ki…
mistic Feb 10, 2020
69c7ad0
chore(na): remove passthrough
mistic Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/legacy/server/logging/log_reporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ import LogFormatJson from './log_format_json';
import LogFormatString from './log_format_string';
import { LogInterceptor } from './log_interceptor';

// NOTE: legacy logger creates a new stream for each new access
mistic marked this conversation as resolved.
Show resolved Hide resolved
// In https://github.com/elastic/kibana/pull/55937 we reach the max listeners
// default limit of 10 for process.stdout which starts a long warning/error
// thrown every time we start the server.
// In order to keep using the legacy logger until we remove it I'm just adding
// a new hard limit here.
process.stdout.setMaxListeners(15);

export function getLoggerStream({ events, config }) {
const squeeze = new Squeeze(events);
const format = config.json ? new LogFormatJson(config) : new LogFormatString(config);
Expand Down