Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing missed timefilter include #57373

Merged
merged 1 commit into from
Feb 12, 2020
Merged

[ML] Removing missed timefilter include #57373

merged 1 commit into from
Feb 12, 2020

Conversation

jgowdyelastic
Copy link
Member

Last minute rebase of #56358 reintroduced a ui/timefilter include from #57086

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 11, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 11, 2020 21:01
@jgowdyelastic jgowdyelastic self-assigned this Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic changed the title [ML] Removing missed timefilter use [ML] Removing missed timefilter include Feb 11, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

darnautov
darnautov approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 7e753e9 into elastic:master Feb 12, 2020
@jgowdyelastic jgowdyelastic deleted the removing-missed-timefilter branch February 12, 2020 09:07
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 12, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 12, 2020
@jgowdyelastic
[ML] Removing missed timefilter use (elastic#57373)
f2641ae
jgowdyelastic added a commit that referenced this pull request Feb 12, 2020
@jgowdyelastic
[ML] Removing missed timefilter use (#57373) (#57429)
f97e1ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@jgowdyelastic jgowdyelastic

Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @darnautov @alvarezmelissa87