[indexPattern/field] remove "bucketable" property of fields #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently setup a bucketable property on every field in order to detect if the field can be used in a bucket aggregation. When it was discovered that our condition was incorrect we decided that we wanted to lean on Elasticsearch's new strctured error messages rather than trying to maintain a secondary implementation of the validation in Kibana.
|
not sure to understand why but with latest released kibana and ES:
this pull request saved my day (but the root problem is still here: why my "non string" fields are considered as non indexed ?) an idea ? or I open a new issue (about the root cause) ? |
|
corresponding simple mapping template: {
"template": "nginx-*",
"mappings": {
"nginx": {
"properties": {
"@timestamp": {"type": "date"},
"source_host": {"type": "string", "index": "not_analyzed"},
"source_path": {"type": "string", "index": "not_analyzed"},
"module": {"type": "string", "index": "not_analyzed"},
"user_id": {"type": "string", "index": "not_analyzed"},
"user_agent": {"type": "string", "index": "not_analyzed"},
"uri": {"type": "string"},
"uri_path": {"type": "string", "index": "not_analyzed"},
"status": {"type": "integer"},
"root_id": {"type": "string", "index": "not_analyzed"},
"request_id": {"type": "string", "index": "not_analyzed"},
"mother_id": {"type": "string", "index": "not_analyzed"},
"request_length": {"type": "long"},
"reply_length": {"type": "long"},
"recursion": {"type": "string", "index": "not_analyzed"},
"processing_ms": {"type": "string", "index": "not_analyzed"},
"method": {"type": "string", "index": "not_analyzed"},
"from": {"type": "string", "index": "not_analyzed"},
"client_priority": {"type": "string", "index": "not_analyzed"},
"duration": {"type": "double"}
}
}
}
} |
This was referenced Jan 10, 2016
Clicking "Visualize" from Discover field pane results in java.lang.IllegalStateException error
#5873
Closed
|
I don't understand why this was merged? I didn't review it, and this definitely should not be in 4.5.0 anyway? |
|
@spalger Who reviewed this? |
3 tasks
|
@rashidkpc to be honest, I'm not sure who reviewed it, but I'm confident that I didn't just merge it... It didn't get backported to 4.5 so no worries there. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3335
Fixes #5914
We currently setup a
bucketableproperty on every field in order to detect if the field can be used in a bucket aggregation. When it was discovered that our condition was incorrect we decided that we wanted to lean on Elasticsearch's new structured error messages rather than trying to maintain a secondary implementation of the validation in Kibana.