Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NP] Import saved objects styles directly #58208

Merged
merged 8 commits into from
Feb 27, 2020
Merged

[NP] Import saved objects styles directly #58208

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9f42b6e
Merge remote-tracking branch 'kibana/master' into saved_objects_scc
maryia-lapata Feb 21, 2020
56ec814
Import styles for saved objects
maryia-lapata Feb 21, 2020
a90b2b5
Merge branch 'master' into saved_objects_scc
elasticmachine Feb 24, 2020
80b09d2
Merge branch 'master' into saved_objects_scc
elasticmachine Feb 24, 2020
060819c
Merge branch 'master' into saved_objects_scc
elasticmachine Feb 26, 2020
168aad7
Merge branch 'master' into saved_objects_scc
elasticmachine Feb 26, 2020
df9c4cb
Rename index.scss
maryia-lapata Feb 26, 2020
d1b4019
Merge branch 'master' into saved_objects_scc
elasticmachine Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/legacy/ui/public/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
@import './error_url_overflow/index';
@import './exit_full_screen/index';
@import './field_editor/index';
@import './saved_objects/index';
@import './share/index';
@import './style_compile/index';
@import '../../../plugins/management/public/components/index';
Expand Down
1 change: 0 additions & 1 deletion src/legacy/ui/public/saved_objects/_index.scss
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions src/plugins/saved_objects/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

import { Plugin } from 'src/core/public';

import './_index.scss';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pattern now is that if the SASS file is imported only and directly in a JS file, it should no longer use the _ pattern. So the file name and this import should change to index.scss


export class SavedObjectsPublicPlugin implements Plugin {
public setup() {}
public start() {}
Expand Down