Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow duplicate percentiles (#57444) #58299

Merged
merged 13 commits into from
Mar 2, 2020
Merged

Disallow duplicate percentiles (#57444) #58299

merged 13 commits into from
Mar 2, 2020

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Feb 22, 2020 •
edited
Loading

Summary

Added an option for disallowing duplicates in the number list component. Enabled this option in the percentiles editor. Closes #57444.

Screenshot_2

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson
Added an optional validation step to the number_list component to dis…
9c2e6e6 
…allow duplicates. Enabled this option in the percentiles editor. Added unit / integration tests
@ThomThomson
Switched internationalization id to avoid duplication
589a1b0
@ThomThomson ThomThomson added v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ThomThomson ThomThomson linked an issue Feb 24, 2020 that may be closed by this pull request
Forbid specifying the same percentile multiple times #57444
Closed
@ThomThomson ThomThomson marked this pull request as ready for review February 25, 2020 14:22
@ThomThomson ThomThomson requested a review from a team February 25, 2020 15:49
@timroes timroes self-requested a review February 25, 2020 17:21
@cchaos cchaos requested a review from gchaps February 25, 2020 17:28
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

timroes
timroes approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome Linux, works. Code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 4696736 into elastic:master Mar 2, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 3, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
5184196 
* master: (26 commits)
  [Endpoint] Alert Details Overview (elastic#58412)
  Service map language icons (elastic#58633)
  [SIEM] [Case] Comments to case view (elastic#58315)
  Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775)
  [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627)
  Dashboard a11y tests (elastic#58122)
  Downgrade "setting up plugin" log to debug (elastic#58776)
  [CI] Pipeline refactoring (elastic#56447)
  [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511)
  put params into short url instead of behind it (elastic#58846)
  show timepicker in timelion and tsvb (elastic#58857)
  improve graph missing workspace error message (elastic#58876)
  [Maps] direct Discover "visualize" to open Maps application (elastic#58549)
  Disallow duplicate percentiles (elastic#57444) (elastic#58299)
  removing references to visTypes uiExports (elastic#58337)
  [SIEM] Default the Timeline events filter to show All events (elastic#58953)
  [Remote clusters] Add indexManagement as required plugin (elastic#58915)
  [DOCS] Rework of main get started page (elastic#58260)
  [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348)
  [Endpoint] add resolver middleware (elastic#58288)
  ...
dgieselaar pushed a commit to dgieselaar/kibana that referenced this pull request Mar 3, 2020
@ThomThomson @dgieselaar
Disallow duplicate percentiles (elastic#57444) (elastic#58299)
3acc2e8 
Added an optional validation step to the number_list component to disallow duplicates, Reworked and consolidated number_list component validations into one method and enabled this option in the percentiles editor. Added unit / integration tests
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 3, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58299 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58299 or prevent reminders by adding the backport:skip label.

@ThomThomson ThomThomson mentioned this pull request Mar 4, 2020
Merged
ThomThomson added a commit that referenced this pull request Mar 5, 2020
@ThomThomson
Disallow duplicate percentiles (#57444) (#58299) (#59360)
0c12506 
Added an optional validation step to the number_list component to disallow duplicates, Reworked and consolidated number_list component validations into one method and enabled this option in the percentiles editor. Added unit / integration tests
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 5, 2020
@rashmivkulkarni rashmivkulkarni mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme left review comments

@gchaps gchaps gchaps left review comments

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
Feature:Vis Editor Visualization editor issues release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbid specifying the same percentile multiple times
6 participants
@ThomThomson @elasticmachine @kibanamachine @timroes @nickofthyme @gchaps