Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uiAppTemplate] display errors on screen when resources fail to load #5870

Merged
merged 2 commits into from
Jan 11, 2016

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 9, 2016

This simply displays errors on the loading screen when a resource fails to load. These types of errors usually mean that there is an error in the code, and generally require that we keep our eyes on the error console while the page loads. This is a bit more obvious I think...

2016-01-11 05_09_31

@kimjoar
Copy link
Contributor

kimjoar commented Jan 10, 2016

I like this!

Btw, is this always because the build failed and you therefore can't load the file? If so, could we just show one error message, but with a more "descriptive" error msg? Might make it easier to understand what has happened for those building Kibana plugins (otherwise, "why did it fail to load!?"). Maybe something along the lines of:

The build process wasn't able to build all the files. To debug the problem see the Kibana terminal output.

@spalger
Copy link
Contributor Author

spalger commented Jan 11, 2016

Build failures are by far the most common reason files would fail to load, but there are other reasons. I suppose it wouldn't hurt to at least expand the message to say something like check "check the kibana server".

@kimjoar
Copy link
Contributor

kimjoar commented Jan 11, 2016

LGTM 👍

spalger added a commit that referenced this pull request Jan 11, 2016
[uiAppTemplate] display errors on screen when resources fail to load
@spalger spalger merged commit ab4746a into elastic:master Jan 11, 2016
@spalger spalger deleted the implement/fileLoadingErrorDisplay branch February 25, 2016 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants