Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix histogram extended bounds persisting after deselection #5960

Merged
merged 1 commit into from
Mar 11, 2016
Merged

fix histogram extended bounds persisting after deselection #5960

merged 1 commit into from
Mar 11, 2016

Conversation

michaelcheng924
Copy link

UPDATE: WIP

Might need to fix some tests, but this code fixes the problem. Fixes #5898.

TODO:

  • check/fix tests

Now:
emptyfixed

Before:
empty

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@michaelcheng924
Copy link
Author

Fixed and added a test. The extended_bounds entered is preserved if the user re-checks the checkbox, so if they check it again, their previously entered values are still there. But now, when they uncheck the checkbox, the chart no longer displays the extended bounds, which my additional test covers.

@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

jenkins, test it

@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

@michaelcheng429 I modified your original post to use the format Fixes #XYZ so github automatically closes the corresponding issue on merge.

@epixa epixa added the review label Feb 8, 2016
@epixa
Copy link
Contributor

epixa commented Feb 8, 2016

This needs to be rebased on master or have master merged into it.

@michaelcheng924
Copy link
Author

Rebased on master @epixa

@epixa
Copy link
Contributor

epixa commented Feb 10, 2016

jenkins, test it

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@rashidkpc
Copy link
Contributor

LGTM

rashidkpc pushed a commit that referenced this pull request Mar 11, 2016
fix histogram extended bounds persisting after deselection
@rashidkpc rashidkpc merged commit afff70c into elastic:master Mar 11, 2016
@epixa epixa added the v5.0.0 label Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram extended bounds persists after deselection
4 participants