-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data Paste Sample Logs Screen #6005
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
edea944
begin working on Add Data paste screen
Bargs 8e8e800
attempt to parse the logs as json, falling back on treating them as s…
Bargs 5321f55
Adding some additional instructions for filebeat
Bargs 8c9ce1d
give the sample log textarea 100% width
Bargs 28bfb8d
Merge branch 'feature/ingest' into ingest/paste
Bargs f531206
Persist provided raw samples when the user navigates back to step 1 f…
Bargs ef408b7
use controller as context instead of accessing directly
Bargs edd950a
use import instead of require
Bargs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
14 changes: 12 additions & 2 deletions
14
src/plugins/kibana/public/settings/sections/indices/add_data_steps/paste_samples_step.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,13 @@ | ||
<h2>Paste samples step</h2> | ||
<div class="wizard-step-title"> | ||
<h3>Provide some sample logs</h3> | ||
Paste in one or more lines from the file you intend to tail. We'll use these samples in the following steps to help | ||
you build an ingest pipeline and configure a Kibana index pattern. Log lines can be raw strings or | ||
formatted as JSON. If your logs are raw strings but you intend to use | ||
<a target="_window" href="https://www.elastic.co/guide/en/beats/filebeat/current/exported-fields.html">Filebeat's metadata</a>, | ||
you'll want to paste the JSON as it will come out of Filebeat. | ||
</div> | ||
|
||
<div class="paste-samples"> | ||
<textarea ng-model="pasteStep.rawSamples" placeholder="Paste your sample log lines here, separated by a newline"></textarea> | ||
</div> | ||
|
||
<button ng-click="samples = 'some sample logs'">Do Stuff</button> |
30 changes: 27 additions & 3 deletions
30
src/plugins/kibana/public/settings/sections/indices/add_data_steps/paste_samples_step.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind using
import
here? several prs are working on moving everything this way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I'll make sure to use import in the future as well.