Node ingest new simulate pipeline merge #6071
Conversation
BigFunger
commented
Feb 2, 2016
BigFunger
commented
- adds the simulate endpoint to kibana server
- adds the pipeline_setup and related directives
I'm not sold on this structure yet. The organization that @spalger suggested to me makes a lot of sense. Especially as we expand the files that are consumed on both the server and client. We need to discuss this. |
We already have #5459 for discussing this structure, and both Spencer and Tim supported the public/server/common directory layout. Rather than block this PR with debate on the issue, I'd rather make it consistent with what's already shipped in master so that if a decision is reached in #5459, it will be easy to refactor. |
| @@ -31,19 +31,17 @@ | |||
|
|
|||
| <div ng-switch="wizard.currentStep"> | |||
| <div ng-switch-when="0"> | |||
| <paste-samples-step samples="wizard.stepResults.samples"></paste-samples-step> | |||
| <paste-samples-step samples="wizard.stepResults.sampleDocs"></paste-samples-step> | |||
There was a problem hiding this comment.
This needs to be changed back to samples. samples is the unprocessed data from the user, wrapped in JSON for the pipeline creation step to consume. sampleDocs is the simulated output from the pipeline, which gets passed to the index pattern review step. My paste step PR #6005 adds another variable called rawSamples which is the untouched user input.
In other words:
rawSamples - user input for step 1
samples - JSON wrapped user input, output of step 1, input for step 2
sampleDocs - Simulated pipeline output, output of step 2, input for step 3
|
@BigFunger I think the best thing we can do tomorrow is split the server side code out into its own PR and work on (unit and functional)tests/documentation for it. That'll probably be the best use of our time so that I can pick up the work more easily once you move on. |
| @@ -0,0 +1,50 @@ | |||
| const _ = require('lodash'); | |||
There was a problem hiding this comment.
I'd love to see some tests for this file with expected inputs and outputs. Documentation in the PR description for the response payload schema would also be extremely helpful.
|
Closing this PR now that's being broken into smaller pieces like #6121 |
