Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry for doc table details #6105

Merged
merged 7 commits into from
Feb 5, 2016
Merged

Add registry for doc table details #6105

merged 7 commits into from
Feb 5, 2016

Commits on Feb 4, 2016

  1. Add registry for doc table details

    Trevan Richins committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    0af354f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'kibana/master' into doc-detail-views-re… 

    …gistry

Conflicts:
	src/plugins/kibana/index.js
	src/ui/ui_exports.js
    Trevan Richins committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    19022d2 View commit details
    Browse the repository at this point in the history

  3. [renderDirective] add support for defining scope bindings 

    People can use the `<render-directive>` directive to programatically extend views, but passing values to those views is not as easy. To make it easier we will support defining scope bindings just like directives support, and those bindings will be applied to the isolate scope created for the rendered directive.

The `<render-directive>` the majority of angular 1.4s syntax. The differences include:
 1. `=?` is not implemented
 1. Isolate scopes are always created, even is `scope:` is not defined
    @spalger
    spalger committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    596f350 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'spalger/implement/renderDirectiveScopeB… 

    …indings' into doc-detail-views-registry
    Trevan Richins committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    5a7669c View commit details
    Browse the repository at this point in the history

  5. Resolve review comments 

    Use the new render-directive attr mechanism.
Rename the registry to be more generic
Create default values
Add a name field in case the title has quotes or other characters
Update import code style
    Trevan Richins committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    5d5e8bf View commit details
    Browse the repository at this point in the history

  6. Move doc viewers to plugin

    Trevan Richins committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    c54fbb1 View commit details
    Browse the repository at this point in the history

  7. Fix tests for doc_views

    Trevan Richins committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    ec22f09 View commit details
    Browse the repository at this point in the history