Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[renderDirective] add support for defining scope bindings #6115

Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 4, 2016

People can use the <render-directive> directive to programatically extend views, but passing values to those views is not exactly possible. To make it easier we will support defining scope bindings just like directives support, and those bindings will be applied to the isolate scope created for the rendered directive.

The <render-directive>'s definition object supports the majority of angular 1.4's same options. The differences are:

  1. =? is not supported
  2. Isolate scopes are always created, even is scope: is not defined

People can use the `<render-directive>` directive to programatically extend views, but passing values to those views is not as easy. To make it easier we will support defining scope bindings just like directives support, and those bindings will be applied to the isolate scope created for the rendered directive.

The `<render-directive>` the majority of angular 1.4s syntax. The differences include:
 1. `=?` is not implemented
 1. Isolate scopes are always created, even is `scope:` is not defined
@spalger spalger merged commit 596f350 into elastic:master Feb 5, 2016
@spalger spalger deleted the implement/renderDirectiveScopeBindings branch February 25, 2016 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants