[Canvas] Update Canvas nav links for new platform #61353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
commented
Mar 25, 2020
| export type AppUpdater = (app: AppBase) => Partial<AppUpdatableFields> | undefined; | ||
| export type AppUpdater = ( | ||
| app: AppBase | ||
| ) => Partial<AppUpdatableFields & { activeUrl: string }> | undefined; |
There was a problem hiding this comment.
Had to add this to make sure the type was correct when using it with the KibanaUrlTracker
poffdeluxe
commented
Mar 25, 2020
| import { HomePublicPluginSetup } from '../../../../../src/plugins/home/public'; | ||
| import { initLoadingIndicator } from './lib/loading_indicator'; | ||
| // @ts-ignore untyped local | ||
| import { historyProvider } from './lib/history_provider'; |
There was a problem hiding this comment.
I need to remove this
poffdeluxe
commented
Mar 25, 2020
| @@ -187,6 +187,18 @@ export const legacyAppRegister = (app: App<any>) => { | |||
| ), | |||
| onAppLeave: () => undefined, | |||
| }; | |||
|
|
|||
| if (app.updater$) { | |||
There was a problem hiding this comment.
I noticed that nothing was being done with the app.updater$ here in the legacyAppRegister function so I added this block. It's the same thing that's happening here: https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/kibana/public/local_application_service/local_application_service.ts/#L89
…t history changes
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is renderedStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/nodes·js.Monitoring app Elasticsearch nodes listing with offline node should have an Elasticsearch Cluster Summary Status with correct infoStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/monitoring/elasticsearch/nodes·js.apis Monitoring Elasticsearch nodes with green platinum cluster should return data for 2 active nodesStandard OutStack Traceand 1 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
|
Resolved in #65590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers