Allow exists filter for unindexed fields #6143
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
jimmyjones2
force-pushed
the
filter-unindexed
branch
from
38afdf0
to
206f2e8
Compare
jimmyjones2
force-pushed
the
filter-unindexed
branch
from
206f2e8
to
f4e3226
Compare
|
jenkins, test it |
| @@ -3,8 +3,8 @@ | |||
| <h5 ng-show="!field.details.error">Quick Count <kbn-info info="Top 5 values based on documents in the table" placement="right"></kbn-info> | |||
| <span ng-if="!field.details.error" class="small discover-field-details-count"> | |||
| ( | |||
| <a ng-show="field.indexed" ng-click="updateFilterInQuery('_exists_', field.name, '+')">{{::field.details.exists}}</a> | |||
| <span ng-show="!field.indexed">{{::field.details.exists}}</span> | |||
| <a ng-show="indexPattern.metaFields.indexOf(field.name) === -1" ng-click="updateFilterInQuery('_exists_', field.name, '+')">{{::field.details.exists}}</a> | |||
There was a problem hiding this comment.
We have es6 shims in place, so you can do indexPattern.metaFields.includes(field.name)
There was a problem hiding this comment.
It would also be great if this indented the attributes like so: https://gist.github.com/anonymous/da97415cf745242e2fca
|
@spalger Thanks for the tips, have done the changes as suggested |
|
jenkins, test it |
|
Some test failures here |
|
@epixa Are these related? Seeing failure in visualize which is nowhere near these changes! |
|
jenkins, test it |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
LGMT |
Allow exists filter for unindexed fields
As Elasticsearch uses _field_names the exists filter works for fields regardless of if they are indexed or not. However the filter doesn't work for meta fields, so disable it in that case.
Closes #6142