Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix display single bar in XYChart Bar Vis #61452

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Mar 26, 2020

Summary

Fixes the issue of not proper displaying of a single bar in Lens Bar Chart Vis.

Fixes #60730

minInterval is being passed to elastic-charts (taken from aggsConfig of the column defined as xAccessor). Here's the example screenshot of solution:
image

Checklist

Delete any items that are not applicable to this PR.

@mbondyra mbondyra requested review from a team, wylieconlon and timroes March 26, 2020 13:31
@mbondyra mbondyra added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0 labels Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra changed the title fix: pass mininterval from aggsConfig [Lens] Fix display single bar in XYChart Bar Vis Mar 26, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wylieconlon
Copy link
Contributor

Should probably be tagged 7.8.0 as well

@mbondyra mbondyra merged commit 25221f7 into elastic:master Mar 26, 2020
@mbondyra mbondyra deleted the lens_fix_single_bar branch March 26, 2020 18:32
mbondyra added a commit to mbondyra/kibana that referenced this pull request Mar 27, 2020
mbondyra added a commit that referenced this pull request Mar 27, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] when there's only one bar/record in XYChart, it's not being displayed
4 participants