Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Adds sort rules Cypress test #62700

Merged
merged 5 commits into from
Apr 7, 2020

Conversation

MadameSheema
Copy link
Member

Summary

In this PR we are adding a test in order to check that rules can be correctly sorted.

signal_detection_rules spec ts (1)

In order to test it:

  1. Loads the prebuilt rules using es_archiver
  2. Go to manage signal detection rules
  3. Saves the name of the fifth and seventh rule
  4. Activates the fifth and seventh rule
  5. Sorts the rules by activated
  6. Checks that the name of the first and second rules are the previous fifth and seventh rule.

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 6, 2020
@MadameSheema MadameSheema requested a review from a team as a code owner April 6, 2020 20:15
@MadameSheema MadameSheema self-assigned this Apr 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@@ -18,6 +18,10 @@ export const DELETE_RULE_BULK_BTN = '[data-test-subj="deleteRuleBulk"]';

export const ELASTIC_RULES_BTN = '[data-test-subj="show-elastic-rules-filter-button"]';

export const FIFTH_RULE = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think if this is zero-based indexing this should be renamed to SIXTH_RULE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True!! Thx! changing it now ;)

Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 91a0010 into elastic:master Apr 7, 2020
@MadameSheema MadameSheema deleted the sort-rules branch April 7, 2020 07:19
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Apr 7, 2020
* adds 'singal detection rules' spec

* adds 'Sorts by activated rules' test

* implements 'Sort by activated rules'

* refactors code

* fixes index
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Apr 7, 2020
* adds 'singal detection rules' spec

* adds 'Sorts by activated rules' test

* implements 'Sort by activated rules'

* refactors code

* fixes index
MadameSheema added a commit that referenced this pull request Apr 7, 2020
* adds 'singal detection rules' spec

* adds 'Sorts by activated rules' test

* implements 'Sort by activated rules'

* refactors code

* fixes index
MadameSheema added a commit that referenced this pull request Apr 7, 2020
* adds 'singal detection rules' spec

* adds 'Sorts by activated rules' test

* implements 'Sort by activated rules'

* refactors code

* fixes index
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 7, 2020
* master: (36 commits)
  [data.search.aggs] Remove service getters from agg types (elastic#61628)
  fixing APM internationalization (elastic#62757)
  fix: 🐛 correctly create error on no_matching_indices (elastic#61257)
  [Lens] Remove all legacy imports (elastic#62596)
  Add label for ace editor (elastic#62588)
  [ML] Show better file structure finder explanations (elastic#62316)
  Fix old pathes in eslintrc (elastic#62580)
  [Uptime] Improve Telemetry test (elastic#62428)
  [SIEM] Adds sort rules Cypress test (elastic#62700)
  [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576)
  fixing bug (elastic#62577)
  [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365)
  [Maps] do not show circle border when symbol size is zero (elastic#62644)
  [Maps] Always show current zoom level (elastic#62684)
  bc5 siem rules merge (elastic#62679)
  Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)"
  Fix visual tests (elastic#62660)
  [Telemetry] update crypto packages (elastic#62469)
  [DOCS] Removed references to left (elastic#60807)
  [Maps] Move layers to np maps (elastic#61877)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants