[DOCS] Fixes title out of sequence warnings in breaking changes #63213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Team:Docs
WIP
|
Pinging @elastic/kibana-docs (Team:Docs) |
jinmu03
reviewed
Apr 13, 2020
|
|
||
| Move all of the search service code to Kibana new platform. Also to telete `courier` folder | ||
| and move `getFlattenedObject` to `src/core/utils`. | ||
|
|
There was a problem hiding this comment.
Change "Also to telete" to "Also to delete"
jinmu03
reviewed
Apr 13, 2020
docs/migration/migrate_7_7.asciidoc
Outdated
| [discrete] | ||
| ==== Add addInfo toast to core notifications service | ||
|
|
||
| Added an Info toast to the core notifications service. |
There was a problem hiding this comment.
Please add " This Info toast will be used for the async search notifications"
jinmu03
reviewed
Apr 13, 2020
docs/migration/migrate_7_7.asciidoc
Outdated
| Delete any items that are not applicable to this PR. | ||
| * Delete `FilterStateManager` | ||
| * Delete `QueryFilter` | ||
| * Delete `SavedQuery` re-export from legacy |
There was a problem hiding this comment.
Change to "Delete unused legacy exports FilterStateManager, QueryFilter, and SavedQuery"
|
LGTM |
gchaps
added a commit
to gchaps/kibana
that referenced
this pull request
Apr 16, 2020
…tic#63213) * [DOCS] Add discrete attributes * [DOCS] Addresses title out of sequence warnings * [DOCS] Fixes some formatting in doc * [DOCS] More formatting changes * [DOCS] More clean-up of breaking changes docs * [DOCS] Adds more developer breaking changes * [DOCS] Incorporates review comments * [DOCS] Fixes formatting Co-authored-by: gchaps <chappell_5@yahoo.com>
gchaps
added a commit
that referenced
this pull request
Apr 16, 2020
…) (#63749) * [DOCS] Add discrete attributes * [DOCS] Addresses title out of sequence warnings * [DOCS] Fixes some formatting in doc * [DOCS] More formatting changes * [DOCS] More clean-up of breaking changes docs * [DOCS] Adds more developer breaking changes * [DOCS] Incorporates review comments * [DOCS] Fixes formatting Co-authored-by: gchaps <chappell_5@yahoo.com> Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #63212 and a6c0f4f
This PR fixes the "title out of sequence" warnings in the 7.7 breaking changes content, and adds "discrete" attributes so that the new content is properly embedded.
It is a work in progress, however, because the content seems to be poorly formatted. I think some of the poorly formatted links, for example, are due to differences between Markdown and Asciidoc conventions.
Checklist
Preview: http://kibana_63213.docs-preview.app.elstc.co/guide/en/kibana/7.x/breaking-changes-7.7.html