Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update elastic charts v18.4.1 #64257

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Update elastic charts v18.4.1 #64257

merged 3 commits into from
Apr 23, 2020

Conversation

nickofthyme
Copy link
Contributor

Summary

Update @elastic/charts to v18.4.1

Following elastic/elastic-charts#583

Checklist

@nickofthyme nickofthyme added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes dependencies Pull requests that update a dependency file v7.8.0 labels Apr 22, 2020
@nickofthyme nickofthyme requested a review from a team April 22, 2020 21:38
@nickofthyme nickofthyme requested a review from a team as a code owner April 22, 2020 21:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wylieconlon
wylieconlon approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have also been testing the charts 18.4.1 update for pie charts and it was working as expected

@nickofthyme nickofthyme merged commit bc62913 into elastic:master Apr 23, 2020
@nickofthyme nickofthyme deleted the update-elastic-charts-18-4 branch April 23, 2020 16:59
@nickofthyme nickofthyme mentioned this pull request Apr 23, 2020
Merged
nickofthyme added a commit that referenced this pull request Apr 23, 2020
@nickofthyme
Update elastic charts v18.4.1 (#64257) (#64331)
2408d9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickofthyme @kibanamachine @tylersmalley @wylieconlon