[4.1] Bump node to 4.3.2 #6473
Merged
[4.1] Bump node to 4.3.2 #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like esvm can't launch a 1.4.4 cluster to run the tests on this. |
|
@tylersmalley You need that commit I linked you earlier that includes the updated windows binary path. |
|
Yeah - I also need to fix the Windows binary location. |
tylersmalley
force-pushed
the
4.1-node-4.3.2
branch
from
f987609
to
2a12a15
Compare
|
@epixa, we're all passing now. |
|
Can you also bump the |
tylersmalley
force-pushed
the
4.1-node-4.3.2
branch
from
2a12a15
to
cc9e9af
Compare
|
@epixa, updated |
| @@ -105,7 +105,7 @@ | |||
| "tar": "^1.0.1" | |||
| }, | |||
| "engines": { | |||
| "node": "~0.10 || ~0.12", | |||
There was a problem hiding this comment.
Can remove iojs from the engines, and also add "npm": "2.14.21" to it?
There was a problem hiding this comment.
Yup, will have that updated shortly.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
4.1-node-4.3.2
branch
from
cc9e9af
to
cf2c1b1
Compare
|
LGTM, planning to merge shortly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major version upgrade of node for the 4.4 line, but it's necessary to fix a memory leak in our ssl implementation.
This release of node upgrades the openssl version to address some security fixes.
See https://nodejs.org/en/blog/release/v4.3.2/
For #6153
Backports #6420