Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce visTypeTable bundle size #64778

Merged
merged 3 commits into from
May 11, 2020
Merged

Reduce visTypeTable bundle size #64778

merged 3 commits into from
May 11, 2020

Conversation

mshustov
Copy link
Contributor

Summary

Part of :

Loads TableOptions components lazily.
Reduces the plugin bundle size from 2.4Mb to 2Mb.

For maintainers

@mshustov mshustov added performance Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mshustov mshustov marked this pull request as ready for review April 29, 2020 16:23
@mshustov mshustov requested review from a team and flash1293 April 29, 2020 16:23
@mshustov
Copy link
Contributor Author

mshustov commented May 4, 2020

@elasticmachine merge upstream

@mshustov
Copy link
Contributor Author

@elasticmachine merge upstream

@pgayvallet pgayvallet mentioned this pull request May 11, 2020
Closed
17 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only. Thanks for doing this, @restrry !

@mshustov mshustov added v7.9.0 and removed v7.8.0 labels May 11, 2020
@mshustov mshustov merged commit d293702 into elastic:master May 11, 2020
@mshustov mshustov deleted the reduce-vis_type_table branch May 11, 2020 12:22
@mshustov mshustov mentioned this pull request May 11, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request May 11, 2020
@mshustov @elasticmachine
load VizOptions component lazily (elastic#64778)
6fe36d4 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mshustov added a commit that referenced this pull request May 11, 2020
@mshustov @elasticmachine
load VizOptions component lazily (#64778) (#66006)
f91d9a9 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@tylersmalley tylersmalley mentioned this pull request Mar 30, 2021
Closed
@lizozom lizozom changed the title reduce vis_type_table js bundle size Reduce visTypeTable bundle size Apr 18, 2022
@lizozom lizozom mentioned this pull request Apr 18, 2022
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backported performance release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshustov @elasticmachine @kibanamachine @flash1293