[Canvas] Update Canvas Plugin documentation #65910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
clintandrewhall
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
This looks good. I'd like to make a suggestion, but it's a bit of a pain in the neck: can we link to some of these TS types in the code examples? I think it would make it a lot easier to grep. Might be a good automation, perhaps. Just a suggestion.
Great work.
|
|
||
| > **FATAL** Error: Unmet requirement "interpreter" for plugin "your_plugin_name" | ||
|
|
||
| then your plugin was likely created to work on a previous version of Kibana. Starting with version 7.8, the plugin system was redesigned and caused breaking changes to these earlier plugins. |
There was a problem hiding this comment.
nit: add link to the release notes on breaking changes
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
* Update Canvas Plugin documentation * Small fix * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> * Update x-pack/plugins/canvas/README.md Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com>
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our README to update to latest Plugin development recommendations.