[config] server name #6610
[config] server name #6610
Conversation
|
cc @tsullivan |
| @@ -1,6 +1,8 @@ | |||
| import _ from 'lodash'; | |||
| import ServerStatus from './server_status'; | |||
| import { join } from 'path'; | |||
| import Config from '../config/config'; | |||
There was a problem hiding this comment.
Looks like this Config class is not used and probably isn't needed.
There was a problem hiding this comment.
Ha, good catch. Looks like I got lucky below with the argument being passed in.
Is this part working right now? Sounds like a good idea. If there is a trick to getting this to work, then I should probably make this work in #6583 too |
|
Yeah it's working, added at https://github.com/elastic/kibana/pull/6610/files#diff-bbc3767b7d939a9b80a1c63afd63bb1eR19 |
|
Is there a reason to have this and the UUID? |
|
@spalger This would be more for human consumption, identifying a server by display name. |
Correct. Also, we won't assume that the instance name is persistent - the user can rename the instance and past metrics will still be associated when you look at a span of historical data, because metrics are grouped by the persistent UUID. |
|
Cool, I like it |
| @@ -11,6 +11,9 @@ | |||
| # The maximum payload size in bytes for incoming server requests. | |||
| # server.maxPayloadBytes: 1048576 | |||
|
|
|||
| # The Kibana server's name. This is used for display purposes. | |||
There was a problem hiding this comment.
Given that we don't actually show this anywhere, this is a weird description. Can you add the display of this to the status and about screens of kibana?
|
@rashidkpc added: |
|
Love it, ship it. |
In cases when multiple instances of Kibana are running it can be useful to provide a name for identification. The intent for this config is to only be used for display purposes.
This adds a server.name config that defaults to the machines hostname, and adds the name to
/api/statusresponses.Open to random names if that's something we want, keeping it simple initially.
Sibling to #6583