unskip _async_dashboard test after fix in PR# 66322 #66517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededTo update your PR or re-run it, just comment with: |
|
Passed 50 times with no failures on flaky test runner;
|
LeeDr
added
Team:QA
|
Pinging @elastic/kibana-qa (Team:QA) |
|
FYI, @spalger |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
May 14, 2020
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
May 14, 2020
LeeDr
pushed a commit
that referenced
this pull request
May 14, 2020
LeeDr
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unskip x-pack/test/functional/apps/dashboard/_async_dashboard.ts
The reason it was failing was it was trying to click the Remove button on sample data as soon as the button was found. But I think the state of the button changes after it is rendered because there is a check if the data is installed, and a security check if the user has permission to remove it.
The fix in #66322 waits for the remove button to be visible and enabled.
Ref to the PR that skipped this test: #65949
Checklist
Delete any items that are not applicable to this PR.