lint import from restricted zones for export exressions #66588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
commented
May 14, 2020
| @@ -7,15 +7,26 @@ | |||
| export { | |||
| transformError, | |||
| buildSiemResponse, | |||
| } from '../../siem/server/lib/detection_engine/routes/utils'; | |||
| } from '../../siem/server/lib/detection_engine/routes/utils'; // eslint-disable-line @kbn/eslint/no-restricted-paths | |||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | |||
| export { deleteTemplate } from '../../siem/server/lib/detection_engine/index/delete_template'; | |||
There was a problem hiding this comment.
can it be exported from '../../siem/server? @elastic/siem-security-team
There was a problem hiding this comment.
Yep, we'll do that in a followup, thanks @restrry 👍
There was a problem hiding this comment.
I will handle this in a follow up PR from my side. Appreciate this fix
flash1293
approved these changes
May 14, 2020
kindsun
approved these changes
May 14, 2020
cjcenizal
approved these changes
May 14, 2020
jen-huang
approved these changes
May 14, 2020
afharo
approved these changes
May 14, 2020
spalger
approved these changes
May 14, 2020
chrisronline
approved these changes
May 14, 2020
walterra
approved these changes
May 15, 2020
|
@elasticmachine merge upstream |
jonathan-buttner
approved these changes
May 15, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
May 15, 2020
* line restricted zones for export exressions * more robust rule * fix or mute eslint errors Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 15, 2020
* master: (191 commits) [Maps] Get number of categories from palette (elastic#66454) move oss features registration to KP (elastic#66524) [kbn/plugin-helpers] typescript-ify (elastic#66513) Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (elastic#66746) FTR: move basic services under common folder (elastic#66563) Migrate Beats Management UI to KP (elastic#65791) [CI] Add 20 minutes to overall build timeout lint import from restricted zones for export exressions (elastic#66588) [SIEM][Detection Engine] Add validation for Rule Actions (elastic#63332) KP plugins shouldn't need package.json (elastic#66654) Replace agent metrics link with the new one (elastic#66632) [CI] Add one retry to setup step (elastic#66638) [CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (elastic#66580) [docLinks] Add docLinks to CoreSetup. (elastic#66631) [DOCS] Rename monitoring collection from internal to legacy (elastic#65781) unskip newsfeed tests (elastic#66562) [NP] Migrate uiSettings owned by Kibana app (elastic#64321) [ML] Functional tests - stabilize typing in DFA mml input (elastic#66706) [Map] return bounding box for static feature collection without joins (elastic#66607) remove trailing slash in graph sample data links (elastic#66358) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added linting for
exportexpressions as well.Fixed errors whenever it's possible and mute others. Codeowners should correct them later.