Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add welcome screen disabling to common page #66713

Merged
merged 6 commits into from
May 27, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/functional/page_objects/common_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
const loginPage = currentUrl.includes('/login');
const wantedLoginPage = appUrl.includes('/login') || appUrl.includes('/logout');

// Disable the welcome screen if the corresponding environment variable is set
// This is relevant for environments which don't allow to use the yml setting, e.g. cloud production
// It is done here so it applies to logins but also to a login re-use
if (process.env.DISABLE_WELCOME_SCREEN) {
await browser.setLocalStorageItem('home:welcome:show', 'false');
}

if (loginPage && !wantedLoginPage) {
log.debug('Found login page');
if (config.get('security.disableTestUser')) {
Expand Down
4 changes: 0 additions & 4 deletions x-pack/test/functional/page_objects/security_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ export function SecurityPageProvider({ getService, getPageObjects }) {

await PageObjects.common.navigateToApp('login');

// ensure welcome screen won't be shown. This is relevant for environments which don't allow
pheyos marked this conversation as resolved.
Show resolved Hide resolved
// to use the yml setting, e.g. cloud
await browser.setLocalStorageItem('home:welcome:show', 'false');

await testSubjects.setValue('loginUsername', username);
await testSubjects.setValue('loginPassword', password);
await testSubjects.click('loginSubmit');
Expand Down