[SIEM] [Detections] Renames Signals to Alerts #67731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spong
added
release_note:enhancement
Team:SIEM
v8.0.0
v7.9.0
Feature:Detection Rules
|
Pinging @elastic/siem (Team:SIEM) |
2 tasks
rylnd
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
One comment about some potentially missed translations, but: LGTM! Very minimal logical changes so review was a breeze.
Checked it out locally and verified:
- creating rules and generating
signalsalerts - creating/saving timelines
- route redirects
- general clicking around and trying to break things
| } | ||
| ); | ||
|
|
||
| export const SIGNAL_GET_NAME_FAILURE = i18n.translate( | ||
| 'xpack.siem.containers.detectionEngine.signals.errorGetSignalDescription', | ||
| 'xpack.siem.containers.detectionEngine.alerts.errorGetAlertDescription', | ||
| { | ||
| defaultMessage: 'Failed to get signal index name', |
There was a problem hiding this comment.
Should this (and the one below it) be changed? I saw your note about not touching signalsIndex but I see other similar strings being changed so 🤷
There was a problem hiding this comment.
Yeah it was tough to draw the line with some of these, but I left this and the one below as is since it was referencing the signals index and we're not quite sure what that's going to be named yet.
| { | ||
| defaultMessage: 'Failed to get signal index name', | ||
| } | ||
| ); | ||
|
|
||
| export const SIGNAL_POST_FAILURE = i18n.translate( | ||
| 'xpack.siem.containers.detectionEngine.signals.errorPostSignalDescription', | ||
| 'xpack.siem.containers.detectionEngine.alerts.errorPostAlertDescription', | ||
| { | ||
| defaultMessage: 'Failed to create signal index', |
| @@ -7,17 +7,17 @@ | |||
| export interface BasicSignals { | |||
There was a problem hiding this comment.
I think this one should technically be BasicAlerts. Buttt we could also replace it with an inline { signal: AbortSignal } in the few places it's used, too. 🤷♂️
There was a problem hiding this comment.
Yeah, I was 🤷♂️ on that as well as I couldn't tell if BasicSignal was meant to refer to the AbortSignal or SignalSignal. I agree going inline might just be for the best here.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spong
added a commit
to spong/kibana
that referenced
this pull request
Jun 3, 2020
## Summary Resolves elastic#65944 Renames `Signals` -> `Alerts` on the main Detection Engine page. Including: * Timeline Event Selector * Alerts Histogram * Alerts Table Does not include: * `Detections` -> `Alerts` navigation rename * `SignalsByCategory` rename as there already exists an `AlertsByCategory`, verify changing to `ExternalAlertsByCategory` * Anything server-side or related to `siemSignalsIndex` ### Checklist - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
spong
added a commit
that referenced
this pull request
Jun 3, 2020
## Summary Resolves #65944 Renames `Signals` -> `Alerts` on the main Detection Engine page. Including: * Timeline Event Selector * Alerts Histogram * Alerts Table Does not include: * `Detections` -> `Alerts` navigation rename * `SignalsByCategory` rename as there already exists an `AlertsByCategory`, verify changing to `ExternalAlertsByCategory` * Anything server-side or related to `siemSignalsIndex` ### Checklist - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jun 5, 2020
## Summary Resolves elastic#65944 Renames `Signals` -> `Alerts` on the main Detection Engine page. Including: * Timeline Event Selector * Alerts Histogram * Alerts Table Does not include: * `Detections` -> `Alerts` navigation rename * `SignalsByCategory` rename as there already exists an `AlertsByCategory`, verify changing to `ExternalAlertsByCategory` * Anything server-side or related to `siemSignalsIndex` ### Checklist - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #65944
Renames
Signals->Alertson the main Detection Engine page. Including:Does not include:
Detections->Alertsnavigation renameSignalsByCategoryrename as there already exists anAlertsByCategory, verify changing toExternalAlertsByCategorysiemSignalsIndexChecklist