Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Replace var with const/let in the root of ui/public #6881

Merged
merged 2 commits into from
Apr 13, 2016
Merged

[internal] Replace var with const/let in the root of ui/public #6881

merged 2 commits into from
Apr 13, 2016

Commits on Apr 12, 2016

  1. [internal] Replace var with let in root of ui/public 

    This change was applied only to files in the root of the src/ui/public
directory.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

`var foo = 'bar';` becomes `let foo = 'var';`

This was accomplished by replacing:
find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=`
replace: `let $1$2=`
    @epixa
    epixa committed Apr 12, 2016
    Configuration menu
    Copy the full SHA
    469c0bd View commit details
    Browse the repository at this point in the history

  2. [internal] Replace let with const in root of ui/public 

    This change was applied only to files in the root of the src/ui/public
directory.

All instances of `let` were replaced with `const`, and then any instance
that flagged the `no-const-assign` rule in the linter was put back.
    @epixa
    epixa committed Apr 12, 2016
    Configuration menu
    Copy the full SHA
    3ae0909 View commit details
    Browse the repository at this point in the history