[Lens] Add "no data" popover #69147
Merged
[Lens] Add "no data" popover #69147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talked with @lizozom and I'm going to move the specifics of the tour into the data plugin - this way it's easier to extend it later and make it a full tour. The exposed API will just become a boolean flag |
|
Jenkins, test this. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
flash1293
added
v7.9.0
v8.0.0
release_note:enhancement
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
wylieconlon
approved these changes
Jun 25, 2020
| const args = { | ||
| dateRange: { fromDate: '1900-01-01', toDate: '2000-01-01' }, | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| fetchJson: fetchJson as any, |
There was a problem hiding this comment.
Would ts-expect-error work here instead of casting to any?
mbondyra
approved these changes
Jun 26, 2020
lizozom
reviewed
Jun 28, 2020
src/plugins/data/public/ui/query_string_input/no_data_popover.tsx
Outdated
Show resolved
Hide resolved
| }, [ | ||
| setState, | ||
| state.indicateNoData, | ||
| state.query, |
There was a problem hiding this comment.
Why did you have to list attributes that are not used explicitly in the effect? Is it because of prevState? 🤔
There was a problem hiding this comment.
We want to show this popover only on first load - if the user starts to change the configuration, they most likely now how to get data (e.g. by changing the index pattern because the wrong one was pre-selected). Then we don't need the popover anymore.
This is just to be extra safe (as the popover is also hidden when the user interacts with the UI outside of it)
There was a problem hiding this comment.
Might be nice adding a comment on this as this is not trivial behavior
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
|
@lizozom Can be reviewed again. |
lizozom
approved these changes
Jun 30, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 1, 2020
flash1293
added a commit
that referenced
this pull request
Jul 1, 2020
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
cchaos
reviewed
Jul 1, 2020
| title="" | ||
| footerAction={ | ||
| <EuiButtonEmpty | ||
| size="s" |
There was a problem hiding this comment.
@flash1293 Minor nit, can you change/add these props:
size="xs"
flush="right"
color="text"
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
…-based-rbac * upstream/master: (38 commits) Move logger configuration integration test to jest (elastic#70378) Changes observability plugin codeowner (elastic#70439) update (elastic#70424) [Logs UI] Avoid CCS-incompatible index name resolution (elastic#70179) Enable "Explore underlying data" actions for Lens visualizations (elastic#70047) Initial work on uptime homepage API (elastic#70135) expressions indexPattern function (elastic#70315) [Discover] Deangularization context error message refactoring (elastic#70090) [Lens] Add "no data" popover (elastic#69147) [Lens] Move chart switcher over (elastic#70182) chore: add missing mjs extension (elastic#70326) [Lens] Multiple y axes (elastic#69911) skip flaky suite (elastic#70386) fix bug to add timeline to case (elastic#70343) [QA][Code Coverage] Drop catchError and use try / catch instead, (elastic#69198) [QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (elastic#69348) [Metrics UI] Add context.reason and alertOnNoData to Inventory alerts (elastic#70260) Resolver refactoring (elastic#70312) [Ingest Manager] Fix agent ack after input format change (elastic#70335) [eslint][ts] Enable prefer-ts-expect-error (elastic#70022) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58276
This PR adds a popover to the time picker if the initial screen in Lens doesn't have data.
The public extension is this: https://github.com/elastic/kibana/pull/69147/files#diff-af278f7eea53f3bf5b098304f4b386dfR68
There is an optional flag that triggers the tour component (state handled by the query bar component).
Later it's planned to use the same API also in Visualize if there is no data for the current time range.