PR: Provide limit warnings to user when API limits are reached. #69590

bkimmel · 2020-06-18T21:49:12Z

Summary

The goal of this PR is to provide the GTV with facilities to warn users when API limits are reached/exceeded so they know there is more information present than what the GTV can show them.

Notes

Reading nextChild and nextAncestor off of the request in middleware to detect if we hit a limit or not.
Reviewed the basic plan for this PR with the team: We're going to surface the "bare minimum" information for the user to know when they've reached a limit on either (anestors, children, relateds).
Design will decide later how to display this information to the user, the intention of this PR is to make it available on state.
Added selectors and tests.
Related event data is already exposed to the UI through the response from the middleware

bkimmel · 2020-06-18T22:08:12Z

x-pack/plugins/security_solution/public/resolver/store/middleware.ts

@@ -77,15 +77,19 @@ export const resolverMiddlewareFactory: MiddlewareFactory = (context) => {
          }
          const nodeStats: Map<string, ResolverNodeStats> = new Map();
          nodeStats.set(entityId, stats);
+          const limitReached = children.nextChild !== null || ancestry.nextAncestor !== null;


@jonathan-buttner does this seem right to you? If either nextChild or nextAncestor isn't null we know we didn't get all the stuff, right? Is there a similar thing for lifecycle?

Ah my bad @bkimmel totally missed this. So the thing to note is that we're only requesting the default amount for the API. I wonder if we should always request the max?

As for lifecycle in the backend we're operating under the assumption that we'll always be able to retrieve all the lifecycle nodes for the entire request. We may have to address fixing that later though but for now there's no nextLifecycle.

elasticmachine · 2020-06-24T14:26:33Z

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

elasticmachine · 2020-06-24T14:27:23Z

Pinging @elastic/endpoint-app-team (Feature:Resolver)

bkimmel · 2020-06-24T14:27:54Z

@elasticmachine merge upstream

x-pack/plugins/security_solution/public/resolver/store/data/graphing.test.ts

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

kibanamachine · 2020-06-24T22:15:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5c6a453

Build metrics

✅ unchanged

History

💚 Build #55950 succeeded 6e0b932
💔 Build #55920 failed c44578c
💔 Build #55925 failed 1528683
💔 Build #55695 failed abf69d4
💔 Build #55239 failed a46560e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

x-pack/plugins/security_solution/public/resolver/store/data/graphing.test.ts

bkimmel · 2020-06-25T13:34:51Z

https://www.youtube.com/watch?v=9D-QD_HIfjA

* master: (45 commits) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) [ML] DF Analytics: Creation wizard part 3 (elastic#69456) Update Resolver generator script documentation (elastic#69912) [ML] Changes View results button text on new job page (elastic#69809) Add master branch to backport config (elastic#69893) [Ingest Manager] Kibana, not EPR, controls removable packages (elastic#69761) unskips 'Events columns' test (elastic#69684) [ML] Changes the ML overview empty analytics panel text (elastic#69801) [DOCS] Emphasizes where File Data Visualizer is located. (elastic#69812) add the `exactRoute` property to app registration (elastic#69772) Bump backport to 5.4.6 (elastic#69880) [Logs UI] ML log integration splash screen (elastic#69288) Clean up TSVB type client code to conform to the schema (elastic#68519) ...

…tic#69590) * Provide facilties to raise limit warnings for user when API limits are reached.

* master: (90 commits) [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513) [SIEM] Replace WithSource with useWithSource hook (elastic#68722) [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708) rename old siem kibana config to securitySolution (elastic#69874) Remove unused Resolver code (elastic#69914) [Observability] Fixing dynamic return type based on the appName (elastic#69894) [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419) Fixes special clicks and 3rd party icon sizes in nav (elastic#69767) [APM] Catch annotations index permission error and log warning (elastic#69881) [Endpoint][Ingest Manager] minor code cleanup (elastic#69844) [Logs UI] Logs ui context menu (elastic#69915) Index pattern serialize and de-serialize (elastic#68844) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) ...

…) (#69944) * Provide facilties to raise limit warnings for user when API limits are reached.

Brent Kimmel added 2 commits June 18, 2020 17:46

Draft: Provide limit warnings to user when API limits are reached.

58f233a

Draft: Put limit info from Resolver tree request on state

a46560e

bkimmel commented Jun 18, 2020

View reviewed changes

Brent Kimmel added 3 commits June 23, 2020 16:13

Draft: Separate limit information

abf69d4

Adding selector and tests

1a0c5f5

Adding composed selector

c44578c

bkimmel marked this pull request as ready for review June 24, 2020 14:25

bkimmel requested review from a team as code owners June 24, 2020 14:25

bkimmel added v7.9.0 v8.0.0 Team:Endpoint Data Visibility Team managing the endpoint resolver labels Jun 24, 2020

bkimmel added release_note:skip Skip the PR/issue when compiling release notes Feature:Resolver Security Solution Resolver feature labels Jun 24, 2020

bkimmel added the Feature:Endpoint Elastic Endpoint feature label Jun 24, 2020

Merge branch 'master' into gtv/limit-warnings

1528683

bkimmel changed the title ~~Draft: Provide limit warnings to user when API limits are reached.~~ PR: Provide limit warnings to user when API limits are reached. Jun 24, 2020

CI: fixing types

6e0b932

oatkiller reviewed Jun 24, 2020

View reviewed changes

x-pack/plugins/security_solution/public/resolver/store/data/graphing.test.ts Outdated Show resolved Hide resolved

oatkiller reviewed Jun 24, 2020

View reviewed changes

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts Outdated Show resolved Hide resolved

oatkiller reviewed Jun 24, 2020

View reviewed changes

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts Outdated Show resolved Hide resolved

R Austin Review: more logic in selector

5c6a453

bkimmel requested review from oatkiller, jonathan-buttner, michaelolo24 and kqualters-elastic June 24, 2020 22:17

oatkiller approved these changes Jun 25, 2020

View reviewed changes

michaelolo24 reviewed Jun 25, 2020

View reviewed changes

x-pack/plugins/security_solution/public/resolver/store/data/graphing.test.ts Show resolved Hide resolved

michaelolo24 approved these changes Jun 25, 2020

View reviewed changes

bkimmel merged commit 0ef7bb8 into elastic:master Jun 25, 2020

bkimmel deleted the gtv/limit-warnings branch June 25, 2020 14:15

bkimmel mentioned this pull request Jun 25, 2020

[7.x] PR: Provide limit warnings to user when API limits are reached. (#69590) #69944

Merged

oatkiller pushed a commit to oatkiller/kibana that referenced this pull request Jun 25, 2020

PR: Provide limit warnings to user when API limits are reached. (elas…

7fc7eab

…tic#69590) * Provide facilties to raise limit warnings for user when API limits are reached.

bkimmel added a commit that referenced this pull request Jun 25, 2020

PR: Provide limit warnings to user when API limits are reached. (#69590…

b833d6b

…) (#69944) * Provide facilties to raise limit warnings for user when API limits are reached.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Provide limit warnings to user when API limits are reached. #69590

PR: Provide limit warnings to user when API limits are reached. #69590

bkimmel commented Jun 18, 2020 •

edited

Loading

bkimmel Jun 18, 2020

jonathan-buttner Jun 29, 2020

elasticmachine commented Jun 24, 2020

elasticmachine commented Jun 24, 2020

bkimmel commented Jun 24, 2020

kibanamachine commented Jun 24, 2020

bkimmel commented Jun 25, 2020

PR: Provide limit warnings to user when API limits are reached. #69590

PR: Provide limit warnings to user when API limits are reached. #69590

Conversation

bkimmel commented Jun 18, 2020 • edited Loading

Summary

Notes

bkimmel Jun 18, 2020

Choose a reason for hiding this comment

jonathan-buttner Jun 29, 2020

Choose a reason for hiding this comment

elasticmachine commented Jun 24, 2020

elasticmachine commented Jun 24, 2020

bkimmel commented Jun 24, 2020

kibanamachine commented Jun 24, 2020

💚 Build Succeeded

Build metrics

History

bkimmel commented Jun 25, 2020

bkimmel commented Jun 18, 2020 •

edited

Loading