Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create.asciidoc #69662

Closed
wants to merge 1 commit into from
Closed

Update create.asciidoc #69662

wants to merge 1 commit into from

Conversation

SutraHsing
Copy link
Contributor

@SutraHsing SutraHsing commented Jun 23, 2020

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 23, 2020

💚 CLA has been signed

@timroes timroes added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs labels Jun 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KOTungseth KOTungseth added v7.6.0 v7.7.0 v7.8.0 v7.9.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 23, 2020
@KOTungseth
Copy link
Contributor

@SutraHsing before you can merge this PR, you'll need to sign the contributor agreement.

@SutraHsing
Copy link
Contributor Author

I'm a newbie in contributing code. Glad to sign a contributor agreement!

@rudolf
Copy link
Contributor

rudolf commented Jun 24, 2020

@SutraHsing I see you're targeting the 7.8 branch. Unless the fix is version specific, we usually target the master branch and then backport it to the different version branches as required. I'll see if I'm able to change this PR, but if it doesn't work you might have to open a new PR.

@rudolf rudolf marked this pull request as draft June 24, 2020 21:59
@rudolf rudolf changed the base branch from 7.8 to master June 24, 2020 21:59
@rudolf rudolf changed the base branch from master to 7.8 June 24, 2020 22:02
@rudolf
Copy link
Contributor

rudolf commented Jun 24, 2020

I don't think there's a super straight-forward way to change the target of this PR. Could you please do the following to create a new branch off of master apply your changes there and create a new PR from that...

In your local clone of your Kibana fork:

  1. git checkout master
  2. git checkout -b update-saved-objects-docs (or any branch name you want to use)
  3. git cherry-pick 4b4967f (cherry pick your commit to this new branch)
  4. git push
  5. Open a new PR targeting master
  6. Add the same labels as this PR and close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💝community release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs v7.6.0 v7.7.0 v7.8.0 v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants