-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Enhance Inventory View Tooltips #69757
[Metrics UI] Enhance Inventory View Tooltips #69757
Conversation
81ab9ca
to
6639919
Compare
6639919
to
6eb4e6b
Compare
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge, just a couple typos to fix
currentTime, | ||
'', | ||
'', | ||
false // Doesn't sent request until reload() reload is called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: send request, wrote reload
twice
@@ -110,15 +110,22 @@ const requestGroupedNodes = async ( | |||
>(callClusterFactory(client), query, bucketSelector, handleAfterKey); | |||
}; | |||
|
|||
const calcualteIndexPatterBasedOnMetrics = (options: InfraSnapshotRequestOptions) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: calculate
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
* [Metrics UI] Enhance Inventory View Tooltips * Fixing typos * Removing toMetricOpt Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Metrics UI] Enhance Inventory View Tooltips * Fixing typos * Removing toMetricOpt Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
This PR enhances the inventory view tooltips by adding additional metrics when the tooltip is loaded. The data is loaded 250ms after the mouse has been hovering over the node. If the mouse leaves the node the request is canceled.
Checklist
Delete any items that are not applicable to this PR.