[CCR] Fix reducer function when finding missing privileges #70158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
alisonelizabeth
added
the
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jloleysens
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Checked the codebase for other instances where we do this and all the others seem to have the return in the correct position 😬
Thanks for fixing @alisonelizabeth !
|
@alisonelizabeth it looks like we can backport this change to v7.8.1 too, it has the same code, but pre NP migration. |
This was referenced Jun 29, 2020
alisonelizabeth
added a commit
to alisonelizabeth/kibana
that referenced
this pull request
Jun 29, 2020
alisonelizabeth
added a commit
that referenced
this pull request
Jun 29, 2020
alisonelizabeth
added a commit
that referenced
this pull request
Jun 29, 2020
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70000
The issue above describes how to test/reproduce the bug.
The
missingClusterPrivilegesreducer function incorrectly had the return statement inside the conditional, causing the following error:Cannot read property 'push' of undefined.With fix:
Release note
This fixes a bug in Cross-Cluster Replication where the user was prompted with an error message when attempting to use the UI with missing cluster privileges. The user should now be prompted with a message indicating what privileges are missing.