[ui-shared-deps/theme] implement auto-switching theme vars module #70274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
…onical_eui_theme_vars_module
…onical_eui_theme_vars_module
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Jul 1, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 1, 2020
…astic#70274) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally submitted as a part of #66673, but extracted to simplify the original PR.
This implements the
@kbn/ui-shared-deps/thememodule which has three exports:euiThemeVarswill point to the v7 or v8 theme, either light or dark mode, based on the UI Setting value at page loadeuiDarkVars&euiLightVarsspecific pointers to the light/dark theme vars from eui.Imports for
@elastic/eui/dist/eui_theme_light.jsonand@elastic/eui/dist/eui_theme_dark.jsonwill be rewritten to access the exports of the new@kbn/ui-shared-deps/thememodule.To show the module in use I removed the
getTheme()helper from the APM plugin and instead used the import directly inx-pack/plugins/apm/public/plugin.ts. It would be totally reasonable to refactor this further and just import the theme from the location where it's needed, rather than passing it tofetchLandingPageData(), but I wanted to avoid coupling the APM code further to this magic without them asking for it.